HADOOP-18752. Change fs.s3a.directory.marker.retention to "keep" -everything but the switch #5859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
steveloughran
force-pushed
the
s3/HADOOP-18752-marker-retention-keep-branch-3.3
branch
from
3be8800 to
6a2b198
Compare
|
testing: s3 london. this is a backport and as it doesn't include the contentious issue "actually changing the switch" then I'm happy to cherrypick as is. lets see what the tests say now I've rolled back the default |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
steveloughran
commented
Jul 20, 2023
| ``` | ||
|
|
||
| Example: test with `markers=keep` | ||
| This is the default and does not need to be explicitly set. |
|
💔 -1 overall
This message was automatically generated. |
…rything but the switch This change has all of PR apache#5689 *except* for changing the default value of marker retention from keep to delete. 1. leaves the default value of fs.s3a.directory.marker.retention at "delete" 2. no longer prints a message when an S3A FS instances is instantiated with any option other than delete. 3. Updates the directory marker documentation Switching to marker retention improves performance on any S3 bucket as there are no needless marker DELETE requests -leading to a reduction in write IOPS and and any delays waiting for the DELETE call to finish. There are *very* significant improvements on versioned buckets, where tombstone markers slow down LIST operations: the more tombstones there are, the worse query planning gets. Having versioning enabled on production stores is the foundation of any data protection strategy, so this has tangible benefits in production. Marker deletion is *not* compatible with older hadoop releases; specifically - Hadoop branch 2 < 2.10.2 - Any release of Hadoop 3.0.x and Hadoop 3.1.x - Hadoop 3.2.0 and 3.2.1 - Hadoop 3.3.0 Incompatible releases have no problems reading data in stores where markers are retained, but can get confused when deleting or renaming directories. Contributed by Steve Loughran Change-Id: Ic9a05357a4b1b1ff6dfecf8b0f30e1eeedb2fe75
…rything but the switch update testing.md to remove statement that default is keep Change-Id: Ic28ad7d9fe17566ee0603b3f6fc41f27df754222
steveloughran
force-pushed
the
s3/HADOOP-18752-marker-retention-keep-branch-3.3
branch
from
b986515 to
25e9322
Compare
|
💔 -1 overall
This message was automatically generated. |
|
OK, backport has gone in cleanly. This does not change the default value, as discussed, even though I'd like to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has all of PR #5689 except for changing the default value of marker retention from keep to delete.
Switching to marker retention improves performance on any S3 bucket as there are no needless marker DELETE requests -leading to a reduction in write IOPS and and any delays waiting for the DELETE call to finish.
There are very significant improvements on versioned buckets, where tombstone markers slow down LIST operations: the more tombstones there are, the worse query planning gets.
Having versioning enabled on production stores is the foundation of any data protection strategy, so this has tangible benefits in production.
Marker deletion is not compatible with older hadoop releases; specifically
Contributed by Steve Loughran
Change-Id: Ic9a05357a4b1b1ff6dfecf8b0f30e1eeedb2fe75
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?