Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-15413. add dfs.client.read.striped.datanode.max.attempts to fix read ecfile timeout #5829
base: trunk
Are you sure you want to change the base?
HDFS-15413. add dfs.client.read.striped.datanode.max.attempts to fix read ecfile timeout #5829
Changes from 21 commits
5366ce9
e471564
ff4b113
db52c34
bb46dbd
abac7c8
3646123
0a0b5e3
bfc97a8
ff3de47
5099ee3
07a944c
40dd653
a663760
302adf6
35b5dc4
59cd633
56ee12c
cc61a87
5af4ee4
7e4992b
5d597a1
381f5ca
c5afc65
d698a94
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may have been different in the initial implementation, but on the first pass through the
while (true)
,curAttemtps
will already be 1 so there will be no retries by default I think?Check failure on line 4558 in hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
ASF Cloudbees Jenkins ci-hadoop / Apache Yetus
hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml#L4558