-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues. #5816
Conversation
…yConfiguration Of Queues.
…yConfiguration Of Queues.
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@goiri Can you help review this pr? Thank you very much! We added a command to save Queue Policy. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@goiri Can you help review this pr? Thank you very much! |
|
||
@Override | ||
public String toString() { | ||
return "SubClusterIdInfo{ id='" + id + '\'' + '}'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do a single concat:
return "SubClusterIdInfo{ id='" + id + "'}";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your help to review the code! I will modify the code.
...i/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/FederationQueueWeight.java
Show resolved
Hide resolved
@goiri Can you help review the code again? Thank you very much! |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@goiri Can you help to merge this pr into the trunk branch? Thank you very much! I will continue to follow up the batch save federation queue policies. |
@goiri Thank you very much for your help in reviewing the code! |
…yConfiguration Of Queues. (apache#5816)
Description of PR
JIRA: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?