-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-7707. BackPort [GPG] Policy generator framework. #5810
Conversation
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
<description> | ||
The interval at which the policy generator runs, default is one hour | ||
</description> | ||
<name>yarn.federation.gpg.policy.generator.interval-ms</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how we handle this with backports but as the metric is general durations with units, it shouldn't include ms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the reminder. I plan to implement this part according to the new specifications, excluding "ms". I will retain the old configuration and add a new configuration. During parsing, I will handle both configurations. If a user uses the old configuration, I will log a message to inform them.
FederationPolicyUtils.instantiatePolicyManager(conf.getType()); | ||
policyManager.setQueue(queueName); | ||
|
||
// TODO there is currently no way to cleanly deserialize a policy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we planning on fixing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the code carefully, we will improve this todo. Can we fix this in the next PR?
🎊 +1 overall
This message was automatically generated. |
@goiri Can you help to review this PR again? Thank you very much! |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@goiri Can you help to merge this pr into the trunk branch? Thank you very much! |
Description of PR
JIRA: YARN-7707. BackPort [GPG] Policy generator framework.
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?