-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18576. Java 11 JavaDoc fails due to missing package comments #5362
Merged
steveloughran
merged 1 commit into
apache:branch-3.3
from
snmvaughan:feature/HADOOP-18576-3.3
Sep 19, 2023
Merged
HADOOP-18576. Java 11 JavaDoc fails due to missing package comments #5362
steveloughran
merged 1 commit into
apache:branch-3.3
from
snmvaughan:feature/HADOOP-18576-3.3
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
4 tasks
LGTM. @snmvaughan Thanks for your contribution! |
slfan1989
approved these changes
Feb 7, 2023
goiri
approved these changes
Feb 7, 2023
💔 -1 overall
This message was automatically generated. |
…pache#5344) Add JavaDoc comments to package-info.java to avoid errors resulting from the use of Hadoop annotations. Contributed by Steve Vaughan Jr
00b5f7e
to
8abad48
Compare
💔 -1 overall
This message was automatically generated. |
steveloughran
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Add JavaDoc comments to package-info.java to avoid errors resulting from the use of Hadoop annotations.
This is a backport from "HADOOP-18616. Java 11 JavaDoc fails due to missing package comments", which has been relabelled as "HADOOP-18576. Java 11 JavaDoc fails due to missing package comments".
How was this patch tested?
Ran JavaDoc using Java 11 in the Hadoop development environment docker image. There were no errors.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?