HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails #4842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slfan1989
approved these changes
Sep 1, 2022
|
🎊 +1 overall
This message was automatically generated. |
|
@steveloughran - Please help in reviewing whenever you have some free cycles. You have been reviewing same JIRA earlier - #1892. Thanks. |
|
@steveloughran - Please help in reviewing the PR in your free slot. Thanks. |
steveloughran
requested changes
Sep 9, 2022
There was a problem hiding this comment.
looks good; one minor change.
i'm away next week, but @mehakmeet can finish the review/merge
| } catch (IOException e) { | ||
| errorText = e.getMessage(); | ||
| diskException = e; | ||
| if (LOG.isDebugEnabled()) { |
There was a problem hiding this comment.
should just use {} entry for the ctx.localDirs[] ref, let slf4j handle the toString call if needed, and you can then remove the outer debug enabled check
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Below UT failure is not relevant to this PR, its being tracked in different JIRA - HADOOP-18452 |
|
@mehakmeet - I have the addressed the minor change suggested by @steveloughran. Please help in finishing the review/merge |
mehakmeet
reviewed
Sep 14, 2022
There was a problem hiding this comment.
Looks good. Some minor comments.
One more question, The maxCapacity, and the errorText seem to be only done when the file size is known, otherwise(L409), the maxCapacity remains 0 and no errorText in the final Exception message in case file creation fails for unknown file size. Is that intended?
| @@ -396,6 +396,9 @@ public Path getLocalPathForWrite(String pathStr, long size, | |||
| Context ctx = confChanged(conf); | |||
| int numDirs = ctx.localDirs.length; | |||
| int numDirsSearched = 0; | |||
| long maxCapacity = 0; | |||
There was a problem hiding this comment.
comment for a better description of this variable, like "Max capacity in any directory"...
There was a problem hiding this comment.
Will add comment for this variable.
| String dir0 = buildBufferDir(ROOT, 0); | ||
| String dir1 = buildBufferDir(ROOT, 1); | ||
| conf.set(CONTEXT, dir0 + "," + dir1); | ||
| LambdaTestUtils.intercept(DiskErrorException.class, "as the max capacity in any directory is", |
There was a problem hiding this comment.
use String.format() to include the path of the file and size in the 2nd argument for the contained string message to verify if the path and size is being propagated in the error message.
There was a problem hiding this comment.
Will address in next commit.
| @@ -532,4 +533,19 @@ public void testGetLocalPathForWriteForInvalidPaths() throws Exception { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Test to check the LocalDirAllocation for the less space HADOOP-16769. | |||
There was a problem hiding this comment.
nit: Maybe cut the Hadoop Jira, and write what we are doing in the test, like "Test to verify creating files using LocalDirAllocation with file size exceeding any directory capacity"...
There was a problem hiding this comment.
Ack. will do that after this PR
There was a problem hiding this comment.
Sorry didn't get this, why not in this PR? I meant to just change the Javadocs to be more descriptive of the test below.
There was a problem hiding this comment.
My bad, I misunderstood you comment for something else. I will make the change.
ashutoshcipher
force-pushed
the
HADOOP-16769
branch
from
d9c5443 to
4491e83
Compare
|
🎊 +1 overall
This message was automatically generated. |
mehakmeet
reviewed
Sep 15, 2022
| @@ -532,4 +533,19 @@ public void testGetLocalPathForWriteForInvalidPaths() throws Exception { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Test to check the LocalDirAllocation for the less space HADOOP-16769. | |||
There was a problem hiding this comment.
Sorry didn't get this, why not in this PR? I meant to just change the Javadocs to be more descriptive of the test below.
| "p1/x", Long.MAX_VALUE - 1), "Expect a DiskErrorException.", | ||
| () -> dirAllocator.getLocalPathForWrite("p1/x", Long.MAX_VALUE - 1, conf)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Add a blank line after the last bracket.
There was a problem hiding this comment.
Ack, will make this change
Thanks. Updated the description as well |
|
💔 -1 overall
This message was automatically generated. |
ashutoshcipher
force-pushed
the
HADOOP-16769
branch
from
c853ce3 to
ec52220
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
UT failure is not related to this patch. Further tried running this test multiple times in local and its passing. |
|
@mehakmeet - I have addressed your comments. Please help in reviewing it. |
|
Merged, thanks for contributing, @ashutoshcipher can you please cherry-pick the same in branch-3.3. |
ashutoshcipher
added a commit
to ashutoshcipher/hadoop
that referenced
this pull request
Sep 16, 2022
…tion fails (apache#4842) The patch provides detailed diagnostics of file creation failure in LocalDirAllocator. Contributed by: Ashutosh Gupta
|
@mehakmeet - PR for branch-3.3 #4896 |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…tion fails (apache#4842) The patch provides detailed diagnostics of file creation failure in LocalDirAllocator. Contributed by: Ashutosh Gupta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
LocalDirAllocator to provide diagnostics when file creation fails.
JIRA - HADOOP-16769
How was this patch tested?
Added UT to test the patch.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?