Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18403. Fix FileSystem leak in ITestS3AAWSCredentialsProvider #4737

Merged
merged 3 commits into from
Aug 18, 2022
Merged

HADOOP-18403. Fix FileSystem leak in ITestS3AAWSCredentialsProvider #4737

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
984d82b
HADOOP-18403. Fix FileSystem leak in ITestS3AAWSCredentialsProvider
virajjasani Aug 12, 2022
762d33d
add message for better debugging
virajjasani Aug 18, 2022
be4360a
addressing review
virajjasani Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions ...ols/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AAWSCredentialsProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,13 @@ public void testAnonymousProvider() throws Exception {
conf.set(AWS_CREDENTIALS_PROVIDER,
AnonymousAWSCredentialsProvider.class.getName());
Path testFile = getCSVTestPath(conf);
FileSystem fs = FileSystem.newInstance(testFile.toUri(), conf);
assertNotNull(fs);
assertTrue(fs instanceof S3AFileSystem);
FileStatus stat = fs.getFileStatus(testFile);
assertNotNull(stat);
assertEquals(testFile, stat.getPath());
try (FileSystem fs = FileSystem.newInstance(testFile.toUri(), conf)) {
assertNotNull("S3AFileSystem instance must not be null", fs);
assertTrue(fs instanceof S3AFileSystem);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, missed it. Done, thanks

FileStatus stat = fs.getFileStatus(testFile);
assertNotNull("FileStatus with qualified path must not be null", stat);
assertEquals(testFile, stat.getPath());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here.

}
}

}