YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common #4717

ashutoshcipher · 2022-08-07T20:02:45Z

Description of PR

Upgrade JUnit from 4 to 5 in hadoop-yarn-common

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2022-08-07T21:56:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 2s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 104 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 29s		trunk passed
+1 💚	compile	0m 58s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	0m 53s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 51s		trunk passed
+1 💚	mvnsite	0m 57s		trunk passed
+1 💚	javadoc	1m 7s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 54s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 5s		trunk passed
+1 💚	shadedclient	24m 44s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 45s		the patch passed
+1 💚	compile	0m 47s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
-1 ❌	javac	0m 47s	/results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 5 new + 54 unchanged - 9 fixed = 59 total (was 63)
+1 💚	compile	0m 41s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 41s		hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 generated 0 new + 52 unchanged - 4 fixed = 52 total (was 56)
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	0m 32s	/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 122 new + 206 unchanged - 163 fixed = 328 total (was 369)
+1 💚	mvnsite	0m 44s		the patch passed
+1 💚	javadoc	0m 43s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 43s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 47s		the patch passed
+1 💚	shadedclient	24m 24s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 20s		hadoop-yarn-common in the patch passed.
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		112m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/1/artifact/out/Dockerfile
GITHUB PR	#4717
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux d6c66865725b 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `54fc62d`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/1/testReport/
Max. process+thread count	625 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-08-08T01:13:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 2s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 104 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 7s		trunk passed
+1 💚	compile	1m 3s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	0m 52s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 52s		trunk passed
+1 💚	mvnsite	0m 58s		trunk passed
+1 💚	javadoc	1m 6s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 57s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 4s		trunk passed
+1 💚	shadedclient	24m 19s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 43s		the patch passed
+1 💚	compile	0m 47s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	0m 47s		hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 0 new + 54 unchanged - 9 fixed = 54 total (was 63)
+1 💚	compile	0m 43s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 43s		hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 generated 0 new + 52 unchanged - 4 fixed = 52 total (was 56)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 31s	/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 12 new + 198 unchanged - 171 fixed = 210 total (was 369)
+1 💚	mvnsite	0m 44s		the patch passed
+1 💚	javadoc	0m 43s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 42s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 51s		the patch passed
+1 💚	shadedclient	24m 3s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 20s		hadoop-yarn-common in the patch passed.
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		111m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/2/artifact/out/Dockerfile
GITHUB PR	#4717
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux 4971f4dd1315 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `3a52ab5`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/2/testReport/
Max. process+thread count	535 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2022-08-08T14:34:05Z

@ashutoshcipher Thank you very much for your contribution, it is very useful. can you submit it as a subpackage, I feel that the changes are a bit big.

ashutoshcipher · 2022-08-08T14:43:33Z

@ashutoshcipher Thank you very much for your contribution, it is very useful. can you submit it as a subpackage, I feel that the changes are a bit big.

@slfan1989 - Thanks for review and approval. I think its overall one package and we keep it as it. The changes seems be kinda okay not really huge :) May be in further modules - I will try to keep short. Again, Thanks for suggestion.

ashutoshcipher · 2022-08-30T08:20:37Z

@aajisaka - Please help in reviewing the PR. Thanks.

ashutoshcipher · 2022-10-01T17:51:54Z

@aajisaka - Please help in reviewing the PR. Thanks.

ashutoshcipher · 2022-10-09T15:37:58Z

@aajisaka Please help in reviewing the PR. Thank a lot.

aajisaka · 2022-11-07T15:18:43Z

Thank you @ashutoshcipher for your patch. I reviewed 57 out of 105 files and now I have no comments. I'll review the rest tomorrow.

ashutoshcipher · 2022-11-07T15:20:12Z

Thank you so much @aajisaka

aajisaka

+1. Thank you @ashutoshcipher for completing the upgrades in YARN

aajisaka · 2022-11-08T08:37:40Z

I want to check if there's other YARN modules depend on the test class in hadoop-yarn-common before merging this.

ashutoshcipher · 2022-11-08T09:05:37Z

Will trigger jenkins by adding a temp empty line in hadoop-yarn-project/pom.xml to make sure all the YARN tests run fine.

ashutoshcipher · 2022-11-11T04:14:27Z

@aajisaka - I am not able trigger jenkins. I dont see any merge conflict as well. Can you please have a look? Thanks.

aajisaka · 2022-11-14T01:41:31Z

CONFLICT (content): Merge conflict in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/BasePBImplRecordsTest.java

I could reproduce it. It's related to YARN-11294. Would you rebase it for the latest trunk? I'm not sure why GitHub doesn't complain about it.

Trigger Build

ashutoshcipher · 2022-11-14T02:00:49Z

Thanks @aajisaka, will do that.

hadoop-yetus · 2022-11-14T09:35:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 55s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 2s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 104 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 37s		Maven dependency ordering for branch
+1 💚	mvninstall	28m 55s		trunk passed
+1 💚	compile	10m 45s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	9m 8s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	2m 4s		trunk passed
+1 💚	mvnsite	6m 51s		trunk passed
+1 💚	javadoc	4m 23s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 37s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	14m 38s		trunk passed
+1 💚	shadedclient	36m 5s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	36m 28s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 25s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 31s		the patch passed
+1 💚	compile	9m 59s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	9m 59s		hadoop-yarn-project-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 0 new + 723 unchanged - 9 fixed = 723 total (was 732)
+1 💚	compile	9m 5s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	9m 5s		hadoop-yarn-project-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 generated 0 new + 639 unchanged - 4 fixed = 639 total (was 643)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 51s	/results-checkstyle-hadoop-yarn-project.txt	hadoop-yarn-project: The patch generated 12 new + 196 unchanged - 171 fixed = 208 total (was 367)
+1 💚	mvnsite	6m 22s		the patch passed
+1 💚	javadoc	4m 1s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 28s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	15m 0s		the patch passed
+1 💚	shadedclient	35m 59s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 29s		hadoop-yarn-common in the patch passed.
-1 ❌	unit	251m 19s	/patch-unit-hadoop-yarn-project.txt	hadoop-yarn-project in the patch passed.
+1 💚	asflicense	1m 13s		The patch does not generate ASF License warnings.
		462m 13s

Reason	Tests
Failed junit tests	hadoop.yarn.server.router.webapp.TestFederationWebApp
	hadoop.yarn.server.router.webapp.TestRouterWebServicesREST

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/8/artifact/out/Dockerfile
GITHUB PR	#4717
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux bba1cd345083 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `3b21d45`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/8/testReport/
Max. process+thread count	1751 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project U: hadoop-yarn-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/8/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

…into YARN-6946

hadoop-yetus · 2022-11-15T11:10:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 5s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 2s		No case conflicting files found.
+0 🆗	codespell	0m 2s		codespell was not available.
+0 🆗	detsecrets	0m 2s		detect-secrets was not available.
+0 🆗	xmllint	0m 2s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 104 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 24s		Maven dependency ordering for branch
+1 💚	mvninstall	29m 5s		trunk passed
+1 💚	compile	11m 3s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	9m 11s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	2m 3s		trunk passed
+1 💚	mvnsite	7m 43s		trunk passed
+1 💚	javadoc	4m 54s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	4m 8s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	15m 28s		trunk passed
+1 💚	shadedclient	35m 4s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	35m 25s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 25s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 55s		the patch passed
+1 💚	compile	10m 3s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	10m 3s		hadoop-yarn-project-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 0 new + 723 unchanged - 9 fixed = 723 total (was 732)
+1 💚	compile	9m 4s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	9m 4s		hadoop-yarn-project-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 generated 0 new + 639 unchanged - 4 fixed = 639 total (was 643)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 52s	/results-checkstyle-hadoop-yarn-project.txt	hadoop-yarn-project: The patch generated 12 new + 196 unchanged - 171 fixed = 208 total (was 367)
+1 💚	mvnsite	7m 5s		the patch passed
+1 💚	javadoc	4m 28s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 55s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	15m 54s		the patch passed
+1 💚	shadedclient	35m 52s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 29s		hadoop-yarn-common in the patch passed.
+1 💚	unit	0m 34s		hadoop-yarn-server-router in the patch passed.
+1 💚	unit	243m 24s		hadoop-yarn-project in the patch passed.
+1 💚	asflicense	1m 14s		The patch does not generate ASF License warnings.
		459m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/9/artifact/out/Dockerfile
GITHUB PR	#4717
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux 591baf25293d 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `f570120`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/9/testReport/
Max. process+thread count	1853 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project U: hadoop-yarn-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/9/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ashutoshcipher · 2022-11-15T11:14:36Z

@aajisaka - Results looks good to me. Can you also check once?

If it looks good to you, I can revert the empty line changes made in this file - hadoop-yarn-project/pom.xml and update the PR.

Thanks.

aajisaka · 2022-11-21T05:15:22Z

Thank you @ashutoshcipher The test result looks good to me. Could you revert the empty line change?

ashutoshcipher · 2022-11-21T05:16:26Z

Thanks @aajisaka I will revert that

ashutoshcipher · 2022-11-21T05:24:23Z

Thank you @ashutoshcipher The test result looks good to me. Could you revert the empty line change?

@aajisaka - Done in my last commit.

aajisaka

+1

aajisaka · 2022-11-21T05:40:57Z

Thank you @ashutoshcipher for your contribution and thank you @slfan1989 for your review! Also, thank you for cleaning up bunch of checkstyle issues :)

hadoop-yarn-project: The patch generated 12 new + 196 unchanged - 171 fixed = 208 total (was 367)

ashutoshcipher · 2022-11-21T05:54:28Z

Thanks @aajisaka for reviewing and merging.

hadoop-yetus · 2022-11-21T08:12:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 53s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 2s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 104 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	29m 1s		trunk passed
+1 💚	compile	10m 41s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	9m 6s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	2m 5s		trunk passed
+1 💚	mvnsite	2m 1s		trunk passed
+1 💚	javadoc	2m 4s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 55s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 23s		trunk passed
+1 💚	shadedclient	24m 23s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	24m 48s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 24s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 8s		the patch passed
+1 💚	compile	9m 58s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	9m 58s		hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 0 new + 723 unchanged - 9 fixed = 723 total (was 732)
+1 💚	compile	9m 9s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	9m 9s		hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 generated 0 new + 639 unchanged - 4 fixed = 639 total (was 643)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 54s	/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt	hadoop-yarn-project/hadoop-yarn: The patch generated 12 new + 196 unchanged - 171 fixed = 208 total (was 367)
+1 💚	mvnsite	1m 49s		the patch passed
+1 💚	javadoc	1m 46s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 41s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 22s		the patch passed
+1 💚	shadedclient	24m 33s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 43s		hadoop-yarn-common in the patch passed.
+1 💚	unit	0m 49s		hadoop-yarn-server-router in the patch passed.
+1 💚	asflicense	1m 2s		The patch does not generate ASF License warnings.
		168m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/10/artifact/out/Dockerfile
GITHUB PR	#4717
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux 2323e162b162 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `01b1013`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/10/testReport/
Max. process+thread count	535 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/10/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Co-authored-by: Ashutosh Gupta <[email protected]> Signed-off-by: Akira Ajisaka <[email protected]>

slfan1989 approved these changes Aug 8, 2022

View reviewed changes

ashutoshcipher changed the title ~~[WIP]YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common~~ YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common Aug 8, 2022

ashutoshcipher marked this pull request as ready for review August 8, 2022 14:59

aajisaka approved these changes Nov 8, 2022

View reviewed changes

ashutoshcipher force-pushed the YARN-6946 branch from 02c6f63 to b66218c Compare November 8, 2022 19:05

YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

2778068

ashutoshcipher force-pushed the YARN-6946 branch from b66218c to 2778068 Compare November 8, 2022 20:37

Trigger Build

b040bfb

YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

3c3921e

Trigger Build

Merge branch 'YARN-6946' of https://github.com/ashutoshcipher/hadoop …

f570120

…into YARN-6946

ashutoshcipher force-pushed the YARN-6946 branch from 3b21d45 to f570120 Compare November 15, 2022 03:28

revert empty line change

01b1013

aajisaka approved these changes Nov 21, 2022

View reviewed changes

aajisaka merged commit 2e993fd into apache:trunk Nov 21, 2022

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common (apache#4717)

76f4393

Co-authored-by: Ashutosh Gupta <[email protected]> Signed-off-by: Akira Ajisaka <[email protected]>

slfan1989 mentioned this pull request Jan 30, 2025

[DISCUSS] [JDK17] Upgrade JUnit / JavaDoc from 4 to 5. #7337

Draft

74 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common #4717

YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common #4717

ashutoshcipher commented Aug 7, 2022 •

edited

Loading

hadoop-yetus commented Aug 7, 2022

hadoop-yetus commented Aug 8, 2022

slfan1989 commented Aug 8, 2022

ashutoshcipher commented Aug 8, 2022

ashutoshcipher commented Aug 30, 2022

ashutoshcipher commented Oct 1, 2022

ashutoshcipher commented Oct 9, 2022

aajisaka commented Nov 7, 2022

ashutoshcipher commented Nov 7, 2022

aajisaka left a comment

aajisaka commented Nov 8, 2022

ashutoshcipher commented Nov 8, 2022

ashutoshcipher commented Nov 11, 2022 •

edited

Loading

aajisaka commented Nov 14, 2022

ashutoshcipher commented Nov 14, 2022

hadoop-yetus commented Nov 14, 2022

hadoop-yetus commented Nov 15, 2022

ashutoshcipher commented Nov 15, 2022

aajisaka commented Nov 21, 2022

ashutoshcipher commented Nov 21, 2022

ashutoshcipher commented Nov 21, 2022

aajisaka left a comment

aajisaka commented Nov 21, 2022

ashutoshcipher commented Nov 21, 2022

hadoop-yetus commented Nov 21, 2022

YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common #4717

YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common #4717

Conversation

ashutoshcipher commented Aug 7, 2022 • edited Loading

Description of PR

For code changes:

hadoop-yetus commented Aug 7, 2022

hadoop-yetus commented Aug 8, 2022

slfan1989 commented Aug 8, 2022

ashutoshcipher commented Aug 8, 2022

ashutoshcipher commented Aug 30, 2022

ashutoshcipher commented Oct 1, 2022

ashutoshcipher commented Oct 9, 2022

aajisaka commented Nov 7, 2022

ashutoshcipher commented Nov 7, 2022

aajisaka left a comment

Choose a reason for hiding this comment

aajisaka commented Nov 8, 2022

ashutoshcipher commented Nov 8, 2022

ashutoshcipher commented Nov 11, 2022 • edited Loading

aajisaka commented Nov 14, 2022

ashutoshcipher commented Nov 14, 2022

hadoop-yetus commented Nov 14, 2022

hadoop-yetus commented Nov 15, 2022

ashutoshcipher commented Nov 15, 2022

aajisaka commented Nov 21, 2022

ashutoshcipher commented Nov 21, 2022

ashutoshcipher commented Nov 21, 2022

aajisaka left a comment

Choose a reason for hiding this comment

aajisaka commented Nov 21, 2022

ashutoshcipher commented Nov 21, 2022

hadoop-yetus commented Nov 21, 2022

ashutoshcipher commented Aug 7, 2022 •

edited

Loading

ashutoshcipher commented Nov 11, 2022 •

edited

Loading