HADOOP-18387. Fix incorrect placeholder in hadoop-common #4679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
steveloughran
requested changes
Aug 3, 2022
| @@ -256,9 +256,9 @@ public <T extends FileSystem & Renewable> void removeRenewAction( | |||
| try { | |||
| action.cancel(); | |||
| } catch (InterruptedException ie) { | |||
| LOG.error("Interrupted while canceling token for " + fs.getUri() | |||
| LOG.error("Interrupted while canceling token for {} filesystem." + fs.getUri() | |||
There was a problem hiding this comment.
needs to move the fs.geturi to a param, not string concat
There was a problem hiding this comment.
Thanks for the help reviewing the code, I will fix it.
| @@ -224,7 +224,7 @@ protected void serviceStart() throws Exception { | |||
| bindingDiagnosticDetails(), | |||
| dumpRegistryRobustly(true)); | |||
|
|
|||
| LOG.error(" Failure {}", e, e); | |||
| LOG.error(" Failure {}", e.getMessage(), e); | |||
There was a problem hiding this comment.
-1. to this change
L227 is valid; it calls e.toString on demand and handles any errors raised. the second e forms the stack trace.
e.getMessage() is null on some exceptions, like NPE
|
@steveloughran Please help to review the code again, thank you very much! |
ZanderXu
requested changes
Aug 3, 2022
| LOG.error("Interrupted while canceling token for " + fs.getUri() | ||
| + "filesystem"); | ||
| LOG.debug("Exception in removeRenewAction: {}", ie); | ||
| LOG.error("Interrupted while canceling token for {} filesystem." , fs.getUri()); |
There was a problem hiding this comment.
Remove the useless space before the comma?
There was a problem hiding this comment.
@ZanderXu Thanks for the review, it has been fixed.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
steveloughran
approved these changes
Aug 3, 2022
ZanderXu
approved these changes
Aug 3, 2022
@steveloughran Thanks for helping review the code! |
Thanks also for your help reviewing the code. |
ayushtkn
changed the title
|
Thanks everyone! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…. Contributed by fanshilun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: HADOOP-18387. Fix incorrect placeholder in hadoop-module.