Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HADOOP-18180] remove use of twitter util-core (scala jar) #4114

Closed

Conversation

pjfanning
Copy link
Contributor

Description of PR

the scala 2.11 util-core jar will cause problems for anyone like Spark who use newer scala versions.

How was this patch tested?

CI build - local build

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

steveloughran and others added 11 commits March 25, 2022 19:32
Contributed by Bhalchandra Pandit.

Change-Id: I855f600bb5d3edea3aa859ce49b23060e59c7ac0
Initial merge tuning

* rename test classes, have AbstractHadoopTestBase as the base
* package info files for new packages
* import ordering
* move to intercept() for assertions; ExceptionAsserts is invoking it
  and can be removed in future.

Tests still fail; will document in JIRA

Change-Id: Ib80edd72c30af8dc996acb62aa0e31bf61eebc7a
@pjfanning pjfanning changed the base branch from trunk to feature-HADOOP-18028-s3a-prefetch March 28, 2022 12:37
@pjfanning pjfanning closed this Mar 28, 2022
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 20s #4114 does not apply to feature-HADOOP-18028-s3a-prefetch. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
Subsystem Report/Notes
GITHUB PR #4114
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4114/1/console
versions git=2.17.1
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@pjfanning
Copy link
Contributor Author

replaced by #4115

@pjfanning pjfanning deleted the de-twitter branch April 4, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants