HADOOP-18100: Change scope of inner classes in InodeTree to make them accessible outside package #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… accessible outside package
omalley
requested changes
Feb 1, 2022
There was a problem hiding this comment.
I believe that you are using View FS as the parent class for a non-public class, but your PR should what your goal is. Furthermore, you should make the minimum possible visibility changes because each part of the public API gets locked down and becomes impossible to change.
...mmon-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
Outdated
Show resolved
Hide resolved
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/FsGetter.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
… accessible outside package Addressed review comment and removed unnecessary scope changes
omalley
reviewed
Feb 2, 2022
| @Private | ||
| class FsGetter { | ||
| @InterfaceAudience.LimitedPrivate({"Common"}) | ||
| @InterfaceStability.Evolving /*Evolving for a release,to be changed to Stable */ |
There was a problem hiding this comment.
Sorry, after thinking about this more, we really don't want to guarantee this interface, so it should be InterfaceStability.Unstable.
There was a problem hiding this comment.
Changed this to Unstable
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
omalley
pushed a commit
that referenced
this pull request
Feb 4, 2022
… accessible outside package Fixes #3950 Signed-off-by: Owen O'Malley <[email protected]> Cherry-picked from 3684c7f by Owen O'Malley
omalley
pushed a commit
that referenced
this pull request
Feb 4, 2022
… accessible outside package Fixes #3950 Signed-off-by: Owen O'Malley <[email protected]> Cherry-picked from 3684c7f by Owen O'Malley
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
… accessible outside package Fixes apache#3950 Signed-off-by: Owen O'Malley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HADOOP-18100
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?