YARN-11068. Exclude transitive log4j2 dependency coming from solr 8. #3936

jojochuang · 2022-01-26T05:38:29Z

Description of PR

Exclude transitive log4j2 dependency coming from solr 8

How was this patch tested?

manually verified the output of 'mvn dependency:tree'

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Change-Id: I2abe85e24decbb789afb275051548d70cd624540

Change-Id: I2126f2f918fff45069df9aae5045ab47b00dda79

virajjasani

Makes sense with the ongoing Log4J/Reload4J efforts. +1(non-binding), pending QA

virajjasani · 2022-01-26T07:45:00Z

LICENSE-binary

+org.apache.solr:solr-solrj:8.8.2
+org.apache.solr:solr-core:8.8.2
+org.apache.solr:solr-test-framework:8.8.2


Ah, I guess I missed this while bumping solr version (while fixing maven 3.8 issues).

aajisaka

LGTM

% mvn dependency:tree -pl hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/ | grep log4j
[INFO] |  +- log4j:log4j:jar:1.2.17:compile
[INFO] |  +- org.slf4j:slf4j-log4j12:jar:1.7.30:compile

hadoop-yetus · 2022-01-26T23:13:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	12m 50s		Maven dependency ordering for branch
+1 💚	mvninstall	21m 53s		trunk passed
+1 💚	compile	22m 16s		trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	compile	19m 26s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	mvnsite	25m 30s		trunk passed
+1 💚	javadoc	8m 3s		trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	7m 58s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	shadedclient	35m 15s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s		Maven dependency ordering for patch
+1 💚	mvninstall	22m 24s		the patch passed
+1 💚	compile	22m 43s		the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javac	22m 43s		the patch passed
+1 💚	compile	19m 39s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	19m 39s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	20m 59s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	xml	0m 1s		The patch has no ill-formed XML file.
+1 💚	javadoc	7m 52s		the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	7m 56s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	shadedclient	36m 30s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	786m 55s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 39s		The patch does not generate ASF License warnings.
		1051m 28s

Reason	Tests
Failed junit tests	hadoop.yarn.csi.client.TestCsiClient

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3936/2/artifact/out/Dockerfile
GITHUB PR	#3936
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml shellcheck shelldocs
uname	Linux 50d10fce4d8f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `be2101f`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3936/2/testReport/
Max. process+thread count	3515 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3936/2/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-01-27T05:32:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 0s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	12m 52s		Maven dependency ordering for branch
+1 💚	mvninstall	21m 38s		trunk passed
+1 💚	compile	22m 18s		trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	compile	19m 35s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	mvnsite	25m 44s		trunk passed
+1 💚	javadoc	7m 57s		trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	8m 8s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	shadedclient	35m 26s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s		Maven dependency ordering for patch
+1 💚	mvninstall	22m 27s		the patch passed
+1 💚	compile	24m 48s		the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javac	24m 48s		the patch passed
+1 💚	compile	20m 47s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 47s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	25m 20s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	xml	0m 2s		The patch has no ill-formed XML file.
+1 💚	javadoc	10m 19s		the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	10m 5s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	shadedclient	47m 14s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	1148m 0s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 42s		The patch does not generate ASF License warnings.
		1432m 19s

Reason	Tests
Failed junit tests	hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure
	hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
	hadoop.ipc.TestIPC
	hadoop.yarn.csi.client.TestCsiClient

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3936/1/artifact/out/Dockerfile
GITHUB PR	#3936
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml shellcheck shelldocs
uname	Linux 63c807dc9da3 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `be2101f`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3936/1/testReport/
Max. process+thread count	2559 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3936/1/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

aajisaka · 2022-01-27T15:04:12Z

Merged. Thank you @jojochuang and @virajjasani

…solr 8. (#3936)" This reverts commit 1c01944.

aajisaka · 2022-01-27T15:37:38Z

Sorry I reverted this because there is no Solr jar file in the release tarball. Would you create a new PR without LICENSE-binary change?

…pache#3936) Signed-off-by: Akira Ajisaka <[email protected]>

…solr 8. (apache#3936)" This reverts commit 1c01944.

jojochuang added 2 commits January 26, 2022 13:36

YARN-11068. Exclude transitive log4j2 dependency coming from solr 8.

beafa86

Change-Id: I2abe85e24decbb789afb275051548d70cd624540

Update LICENSE-binary to trigger full test coverage.

be2101f

Change-Id: I2126f2f918fff45069df9aae5045ab47b00dda79

virajjasani approved these changes Jan 26, 2022

View reviewed changes

aajisaka approved these changes Jan 26, 2022

View reviewed changes

aajisaka merged commit 1c01944 into apache:trunk Jan 27, 2022

aajisaka added a commit that referenced this pull request Jan 27, 2022

Revert "YARN-11068. Exclude transitive log4j2 dependency coming from …

02f6bad

…solr 8. (#3936)" This reverts commit 1c01944.

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

YARN-11068. Exclude transitive log4j2 dependency coming from solr 8. (a…

ee5206b

…pache#3936) Signed-off-by: Akira Ajisaka <[email protected]>

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

Revert "YARN-11068. Exclude transitive log4j2 dependency coming from …

4f854ba

…solr 8. (apache#3936)" This reverts commit 1c01944.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARN-11068. Exclude transitive log4j2 dependency coming from solr 8. #3936

YARN-11068. Exclude transitive log4j2 dependency coming from solr 8. #3936

jojochuang commented Jan 26, 2022

virajjasani left a comment

virajjasani Jan 26, 2022

aajisaka left a comment

hadoop-yetus commented Jan 26, 2022

hadoop-yetus commented Jan 27, 2022

aajisaka commented Jan 27, 2022

aajisaka commented Jan 27, 2022

YARN-11068. Exclude transitive log4j2 dependency coming from solr 8. #3936

YARN-11068. Exclude transitive log4j2 dependency coming from solr 8. #3936

Conversation

jojochuang commented Jan 26, 2022

Description of PR

How was this patch tested?

For code changes:

virajjasani left a comment

Choose a reason for hiding this comment

virajjasani Jan 26, 2022

Choose a reason for hiding this comment

aajisaka left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Jan 26, 2022

hadoop-yetus commented Jan 27, 2022

aajisaka commented Jan 27, 2022

aajisaka commented Jan 27, 2022