Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDFS-16435. Remove no need TODO comment for ObserverReadProxyProvider #3912

Merged
merged 1 commit into from
Feb 3, 2022
Merged

HDFS-16435. Remove no need TODO comment for ObserverReadProxyProvider #3912

merged 1 commit into from
Feb 3, 2022

Conversation

tomscut
Copy link
Contributor

@tomscut tomscut commented Jan 21, 2022 •
edited
Loading

JIRA: HDFS-16435.

Based on discussion in HDFS-13923, we don't think need to add a configuration to turn on/off observer reads.

So I suggest removing the TODO comment that are not needed.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 33m 35s trunk passed
+1 💚 compile 1m 5s trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 compile 0m 56s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 0m 30s trunk passed
+1 💚 mvnsite 1m 2s trunk passed
+1 💚 javadoc 0m 47s trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 36s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 2m 36s trunk passed
+1 💚 shadedclient 24m 3s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 54s the patch passed
+1 💚 compile 0m 58s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javac 0m 58s the patch passed
+1 💚 compile 0m 51s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 0m 51s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 20s the patch passed
+1 💚 mvnsite 0m 54s the patch passed
+1 💚 javadoc 0m 36s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 32s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 2m 55s the patch passed
+1 💚 shadedclient 23m 52s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 26s hadoop-hdfs-client in the patch passed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
99m 43s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3912/1/artifact/out/Dockerfile
GITHUB PR #3912
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 2941f32c9bb1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 243d000
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3912/1/testReport/
Max. process+thread count 550 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3912/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@ayushtkn
Copy link
Member

The title and the actual code are poles apart. From the title it looks like you are going to add some config. Where as the actual code is just removing a TODO.
Can you update the title. And add the description why this is no longer a TODO, for people coming in future to know, why this TODO was dropped

@tomscut tomscut changed the title HDFS-13923. Add a configuration to turn on/off observer reads HDFS-13923. Remove no need TODO comment for ObserverReadProxyProvider Jan 24, 2022
@tomscut
Copy link
Contributor Author

tomscut commented Jan 24, 2022

Based on discussion in HDFS-13923, we don't think need to Add a configuration to turn on/off observer reads.

So I suggest removing the TODO comment that are not needed.

Hi @ayushtkn , I am sorry that I did not explain the reason in the PR description.

Based on discussion in HDFS-13923, we don't think need to Add a configuration to turn on/off observer reads. So I suggest removing the TODO comment that are not needed.

I don't know if it is appropriate to change the title of the original ISSUE, this PR is just a suggestion.

@tomscut tomscut changed the title HDFS-13923. Remove no need TODO comment for ObserverReadProxyProvider HDFS-16435. Remove no need TODO comment for ObserverReadProxyProvider Jan 24, 2022
@tomscut
Copy link
Contributor Author

tomscut commented Jan 24, 2022

Based on discussion in HDFS-13923, we don't think need to Add a configuration to turn on/off observer reads.
So I suggest removing the TODO comment that are not needed.

Hi @ayushtkn , I am sorry that I did not explain the reason in the PR description.

Based on discussion in HDFS-13923, we don't think need to Add a configuration to turn on/off observer reads. So I suggest removing the TODO comment that are not needed.

I don't know if it is appropriate to change the title of the original ISSUE, this PR is just a suggestion.

I created a new JIRA HDFS-16435. @ayushtkn Please take a look. Thank you.

@tomscut
Copy link
Contributor Author

tomscut commented Jan 26, 2022

Hi @sunchao , could you please take a look. Thanks.

@ayushtkn
Copy link
Member

It makes sense to me, I honestly don't understand what was the intend of that TODO.
Can you loop in the actual author/reviewer of that code as well to confirm.

@tomscut
Copy link
Contributor Author

tomscut commented Jan 27, 2022

It makes sense to me, I honestly don't understand what was the intend of that TODO.
Can you loop in the actual author/reviewer of that code as well to confirm.

Thanks @ayushtkn for your comments.

sunchao
sunchao approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think HDFS-16435 added it. Haven't touched observer namenode for a while now so not sure if anybody still find a configuration useful.

@tomscut
Copy link
Contributor Author

tomscut commented Jan 28, 2022

I think HDFS-16435 added it. Haven't touched observer namenode for a while now so not sure if anybody still find a configuration useful.

Thanks @sunchao for your review and comment.

@tomscut
Copy link
Contributor Author

tomscut commented Jan 28, 2022

I wanted to implement this todo, but found the discussion in HDFS-13923 quite sensible. We did not think need to add a configuration to turn on/off observer reads. So I suggest removing the todo comment.

@jojochuang @shvachko @xkrogen Could you please also take a look? Thanks a lot.

ayushtkn
ayushtkn approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
If no comments for a couple of days. I think we can go ahead and merge this

@tomscut
Copy link
Contributor Author

tomscut commented Jan 28, 2022

LGTM. If no comments for a couple of days. I think we can go ahead and merge this

Thanks @ayushtkn for the review.

@tomscut
Copy link
Contributor Author

tomscut commented Feb 3, 2022

Hi @sunchao @ayushtkn , could you please merge this? Thanks.

@ayushtkn ayushtkn merged commit b5b07af into apache:trunk Feb 3, 2022
@ayushtkn
Copy link
Member

ayushtkn commented Feb 3, 2022

Sorry I forgot to merge. :-(
Thanx @tomscut for the contribution & @sunchao for the review!!!

@tomscut
Copy link
Contributor Author

tomscut commented Feb 3, 2022

Thanks @ayushtkn.

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
@tomscut
HDFS-16435. Remove no need TODO comment for ObserverReadProxyProvider (…
e607a04 
…apache#3912). Contributed by tomscut.

Reviewed-by: Chao Sun <[email protected]>
Signed-off-by: Ayush Saxena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushtkn ayushtkn ayushtkn approved these changes

@sunchao sunchao sunchao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomscut @hadoop-yetus @ayushtkn @sunchao