-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-11055. Add missing newline in cgroups-operations.c #3851
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
I think the patch is too trivial to add a test but open to a review feedback otherwise |
the changes look fine to me but would be good for someone else active in Hadoop code to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit a94e9fc)
Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit a94e9fc)
Thank you @tgravescs and @aajisaka for reviews! |
Signed-off-by: Akira Ajisaka <[email protected]>
Description of PR
Adding missing newline characters in the end of fprintf format strings in cgroups-operations.c
How was this patch tested?
pseudo-distributed deploy https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/UsingGpus.md#distributed-shell--gpu-with-docker
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?