Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDFS-16395. Remove useless NNThroughputBenchmark#dummyActionNoSynch(). #3823

Merged
merged 1 commit into from
Dec 24, 2021

Conversation

jianghuazhu
Copy link
Contributor

@jianghuazhu jianghuazhu commented Dec 22, 2021

HDFS-16395

Description of PR

It looks like NNThroughputBenchmark#dummyActionNoSynch() has been deprecated and it should be deleted.

How was this patch tested?

For testing, there is not much pressure.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 3s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 35m 23s trunk passed
+1 💚 compile 1m 28s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 1m 19s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 1m 0s trunk passed
+1 💚 mvnsite 1m 27s trunk passed
+1 💚 javadoc 1m 2s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 32s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 21s trunk passed
+1 💚 shadedclient 25m 40s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 18s the patch passed
+1 💚 compile 1m 24s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 1m 24s the patch passed
+1 💚 compile 1m 13s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 1m 13s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 54s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 128 unchanged - 1 fixed = 128 total (was 129)
+1 💚 mvnsite 1m 20s the patch passed
+1 💚 javadoc 0m 53s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 27s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 26s the patch passed
+1 💚 shadedclient 25m 25s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 382m 26s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 46s The patch does not generate ASF License warnings.
491m 12s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3823/1/artifact/out/Dockerfile
GITHUB PR #3823
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 6a3c97535ff4 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 6101a0a
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3823/1/testReport/
Max. process+thread count 2153 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3823/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@jianghuazhu
Copy link
Contributor Author

Could you help review this pr, @jojochuang @ferhui.
Thank you very much.

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (non-binding)

@jianghuazhu
Copy link
Contributor Author

Thank you very much @virajjasani .

@aajisaka aajisaka merged commit a5659fe into apache:trunk Dec 24, 2021
@aajisaka
Copy link
Member

Merged. Thanks @jianghuazhu @ferhui @virajjasani

aajisaka pushed a commit that referenced this pull request Dec 24, 2021
#3823)

Reviewed-by: Fei Hui <[email protected]>
Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit a5659fe)
aajisaka pushed a commit that referenced this pull request Dec 24, 2021
#3823)

Reviewed-by: Fei Hui <[email protected]>
Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit a5659fe)
@aajisaka aajisaka changed the title HDFS-16395.Remove useless NNThroughputBenchmark#dummyActionNoSynch(). HDFS-16395. Remove useless NNThroughputBenchmark#dummyActionNoSynch(). Dec 24, 2021
sunchao pushed a commit that referenced this pull request Jan 4, 2022
#3823)

Reviewed-by: Fei Hui <[email protected]>
Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit a5659fe)
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants