-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16384. Upgrade Netty to 4.1.72.Final #3798
Conversation
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also update the version here? https://github.com/apache/hadoop/blob/trunk/LICENSE-binary#L264
that way, it triggers the full build which is needed to verify a thirdparty update.
Updated License file
Thanks @jojochuang, I've updated the License file. |
💔 -1 overall
This message was automatically generated. |
@jojochuang to me these test failures look unrelated but still would be good to have a green test. Do you have any special command to restart the testing or should I push an empty commit? |
No this is good. We don't use netty for those sub-components so I think we're good here. Will merge later. |
This seems to be breaking trunk:
|
This reverts commit a4557f9.
sorry didn't notice it. reverting it now. |
This reverts commit a4557f9.
This reverts commit a4557f9.
Description of PR
Upgrade Netty to newest available version
How was this patch tested?
Ran unit tests
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?