Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-17904. Test Result Not Working In Jenkins Result. #3413

Merged
merged 2 commits into from
Sep 10, 2021
Merged

HADOOP-17904. Test Result Not Working In Jenkins Result. #3413

merged 2 commits into from
Sep 10, 2021

Conversation

ayushtkn
Copy link
Member

@ayushtkn ayushtkn commented Sep 9, 2021

Working Example:
#2773 (comment)

The Test Report link works in the above build

https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2773/10/testReport/

virajjasani
virajjasani approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (non-binding), thanks a lot @ayushtkn

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 45s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+0 🆗 mvndep 12m 53s Maven dependency ordering for branch
+1 💚 shadedclient 15m 40s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for patch
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 shadedclient 15m 26s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
47m 38s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3413/1/artifact/out/Dockerfile
GITHUB PR #3413
Optional Tests dupname asflicense codespell shellcheck shelldocs
uname Linux c420542b7dd2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / fd40d61
Max. process+thread count 685 (vs. ulimit of 5500)
modules C: U:
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3413/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@ayushtkn ayushtkn requested a review from goiri September 9, 2021 17:19
@goiri
Copy link
Member

goiri commented Sep 9, 2021

This looks good but I don't have a lot of experience here.
@GauthamBanasandra you have been working around here, can you confirm?

GauthamBanasandra
GauthamBanasandra requested changes Sep 9, 2021
View reviewed changes
dev-support/Jenkinsfile
@@ -30,8 +30,9 @@ def publishJUnitResults() {
boolean surefireReportsExist = findCmdExitCode == 0
if (surefireReportsExist) {
echo "XML files found under surefire-reports, running junit"
SRC = "${SOURCEDIR}/**/target/surefire-reports/*.xml".replace("$WORKSPACE/","")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a comment here mentioning that the path must be relative to the checkout dir?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path used to have env.SOURCEDIR prefix before I made this change -

hadoop/dev-support/Jenkinsfile

Line 145 in ef5dbc7

junit "${env.SOURCEDIR}/**/target/surefire-reports/*.xml"
. Wasn't env.SOURCEDIR resolving to the absolute path back then?

Copy link
Member Author

@ayushtkn ayushtkn Sep 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so:

hadoop/dev-support/Jenkinsfile

Line 32 in ef5dbc7

SOURCEDIR = 'src'

Copy link
Member Author

@ayushtkn ayushtkn Sep 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now:
https://github.com/apache/hadoop/blob/trunk/dev-support/Jenkinsfile#L259

                SOURCEDIR = "${WORKSPACE}/ubuntu-focal/src"

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 54s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+0 🆗 mvndep 12m 43s Maven dependency ordering for branch
+1 💚 shadedclient 13m 45s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for patch
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 shadedclient 13m 55s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
44m 59s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3413/2/artifact/out/Dockerfile
GITHUB PR #3413
Optional Tests dupname asflicense codespell shellcheck shelldocs
uname Linux 947f61faaec8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 7c9d751
Max. process+thread count 542 (vs. ulimit of 5500)
modules C: U:
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3413/2/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

iwasakims
iwasakims approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushtkn ayushtkn merged commit 4d18a2e into apache:trunk Sep 10, 2021
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@ayushtkn
HADOOP-17904. Test Result Not Working In Jenkins Result. (apache#3413)…
3eee20a 
…. Contributed by Ayush Saxena.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GauthamBanasandra GauthamBanasandra GauthamBanasandra requested changes

@virajjasani virajjasani virajjasani approved these changes

@goiri goiri goiri approved these changes

@iwasakims iwasakims iwasakims approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ayushtkn @hadoop-yetus @goiri @iwasakims @GauthamBanasandra @virajjasani