HDFS-16210. RBF: Add the option of refreshCallQueue to RouterAdmin #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goiri Could you help to review this PR? |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ferhui
reviewed
Sep 6, 2021
| try (RefreshCallQueueProtocolClientSideTranslatorPB xlator = | ||
| new RefreshCallQueueProtocolClientSideTranslatorPB(proxy)) { | ||
| xlator.refreshCallQueue(); | ||
| System.out.println("Refresh call queue successful for " + hostport); |
There was a problem hiding this comment.
here successfully？the bellow should be unsuccessfully?
There was a problem hiding this comment.
@ferhui Thanks for the review.
Just to be sure, do you mean changing "successful" to "successfully" and "failed" to "unsuccessfully"?
Borrowed from DFSAdmin, but the changes are good to me.
There was a problem hiding this comment.
Uh, it's not my native language. Maybe adverb is more suitable here.
| System.setOut(new PrintStream(out)); | ||
| String[] argv = new String[]{"-refreshCallQueue"}; | ||
| assertEquals(0, ToolRunner.run(admin, argv)); | ||
| assertTrue(out.toString().contains("Refresh call queue successful")); |
|
🎊 +1 overall
This message was automatically generated. |
|
@symious Could you please change the title of PR and JIRA to "RBF: Add xxx", it means that it's for RBF and it convenient for others to track RBF |
symious
changed the title
Sure, updated. |
|
@symious Thanks. Will commit if no other comments. |
goiri
approved these changes
Sep 8, 2021
kiran-maturi
pushed a commit
to kiran-maturi/hadoop
that referenced
this pull request
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
We enabled FairCallQueue to RouterRpcServer, but Router can not refreshCallQueue as NameNode does.
This ticket is to enable the refreshCallQueue for Router so that we don't have to restart the Routers when updating FairCallQueue configurations.
The option is not to refreshCallQueue to NameNodes, just trying to refresh the callQueue of Router itself.
Jira ticket: https://issues.apache.org/jira/browse/HDFS-16210
How was this patch tested?
Unit test
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?