-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16186 Datanode kicks out hard disk logic optimization #3334
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
...p-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImpl.java
Outdated
Show resolved
Hide resolved
use concrete classes instead of "*"
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@jianghuazhu Hello, I’m a novice, I’m not sure if the patch failed is related to my code, can you help me? |
💔 -1 overall
This message was automatically generated. |
Checkstyle issues are because of new code. Take a look at the report - https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3334/7/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt Failed tests you can run locally with & without the patch changes. Looks like impacted with the patch. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- need tests
- we tried many times to make the disk failure handling smarter in the past few years. I doubt it's a good idea to remove a disk only because a file isn't readable. Way too aggressive than necessary.
@jojochuang @prasad-acit @jianghuazhu |
Description of PR
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?