-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-17862. ABFS: Fix unchecked cast compiler warning for AbfsListStatusRemoteIterator #3331
Conversation
TEST RESULTS HNS Account Location: East US 2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
production code looks good.
test wise
- too much duplication going in: makes maintenance harder. please refactor both the remove and the assert on fileNames size
- lots of log @ debug/trace. Are these actual failures? If so they should be assertions. If not, but still a sign of recurrent issues: log at debug. And explain why it happens/why it is harmless.
...-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsListResult.java
Show resolved
Hide resolved
...oop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsListStatusRemoteIterator.java
Outdated
Show resolved
Hide resolved
...oop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsListStatusRemoteIterator.java
Outdated
Show resolved
Hide resolved
...oop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsListStatusRemoteIterator.java
Outdated
Show resolved
Hide resolved
...oop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsListStatusRemoteIterator.java
Outdated
Show resolved
Hide resolved
...oop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsListStatusRemoteIterator.java
Outdated
Show resolved
Hide resolved
Hi @steveloughran, thanks for the review. The transient failure in HADOOP-17797 has been observed in each of these tests: testWithAbfsIteratorDisabled, testWithAbfsIteratorDisabledWithoutHasNext, testAbfsIteratorWithoutHasNext |
💔 -1 overall
This message was automatically generated. |
Yetus error is a WASB side compiler warning tracked in JIRA, and does not involve ABFS code. |
merged into trunk; if you can verify a test run of this cherrypicked works on branch 3.3, i will add there too. thanks. |
…tatusRemoteIterator (apache#3331) closes apache#3331 Contributed by Sumangala Patki
Hadoop yetus run shows a java compiler warning for unchecked casting of
Object
toIterator<FileStatus>
in a method of AbfsListStatusRemoteIterator class. This is resolved by introducing a new class to hold the iterator and exception thrown when applicable.This PR also adds a potential fix and enables logging to facilitate better investigation of the occasional transient failure in the corresponding test class, tracked in HADOOP-17797. The additional logging introduced here affects only the test class for this functionality.