HADOOP-17837: Add unresolved endpoint value to UnknownHostException #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
| @@ -111,6 +111,7 @@ public void testInvalidAddress() throws Throwable { | |||
| fail("Should not have connected"); | |||
| } catch (UnknownHostException uhe) { | |||
| LOG.info("Got exception: ", uhe); | |||
| assertEquals("invalid-test-host:0", uhe.getMessage()); | |||
There was a problem hiding this comment.
Use GenericTestUtils.assertExceptionContains(); this rethrows the exception if there's no match, and allows for extra text in the messge
| @@ -589,7 +589,7 @@ public static void connect(Socket socket, | |||
| } catch (SocketTimeoutException ste) { | |||
| throw new ConnectTimeoutException(ste.getMessage()); | |||
| } catch (UnresolvedAddressException uae) { | |||
| throw new UnknownHostException(uae.getMessage()); | |||
| throw new UnknownHostException(endpoint.toString()); | |||
There was a problem hiding this comment.
we still need that message from the original string so build it from uhe.getMessage() + " " + endpoint
There was a problem hiding this comment.
Thank you for taking a look. I considered this, but a UHE cannot have a message. It only as has no args constructor so it cannot be created with a message. There's also no setMessage method as far as I can tell, so can't be added after. https://docs.oracle.com/javase/8/docs/api/java/net/UnknownHostException.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://issues.apache.org/jira/browse/HADOOP-17837, adds `endpoint.toString() to the UnknownHostException. UnresolvedAddressException cannot have a message, so the current behavior is a UHE with no message as well. Adding the endpoint to the exception will make it easier to debug when these arise.