Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17397. ABFS: SAS Test updates for version and permission update #2492

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

snvijaya
Copy link
Contributor

Below updates are made:

  1. Upgrading the SAS version in Service SAS generator to Feb20 which is the latest server supported version (test code)
  2. Updating the permission in Delegation SAS to "op" from "p" for ACL operation as identities added as suoid/saoid added by tests are not owners of test path (Again test code).
    Relevant public documentation: https://docs.microsoft.com/en-us/rest/api/storageservices/create-user-delegation-sas#specify-a-signed-object-id-for-a-security-principal-preview

Tests were re-run. Test results posted at end of conversation tab.

@snvijaya
Copy link
Contributor Author

HNS-OAuth

[INFO] Results:
[INFO]
[INFO] Tests run: 88, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 445, Failures: 0, Errors: 0, Skipped: 66
[INFO] Results:
[INFO]
[WARNING] Tests run: 208, Failures: 0, Errors: 0, Skipped: 141

NonHNS-OAuth

[INFO] Results:
[INFO]
[INFO] Tests run: 88, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 249
[INFO] Results:
[INFO]
[WARNING] Tests run: 206, Failures: 0, Errors: 0, Skipped: 141

HNS-SharedKey

[INFO] Results:
[INFO]
[INFO] Tests run: 88, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 445, Failures: 0, Errors: 0, Skipped: 24
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] ITestAbfsFileSystemContractRename>AbstractContractRenameTest.testRenameFileOverExistingFile:131->Assert.fail:88 expected rename(abfs://[email protected]/fork-8/test/source-256.txt, abfs://[email protected]/fork-8/test/dest-512.txt) to be rejected with exception, but got false
[INFO]
[ERROR] Tests run: 198, Failures: 1, Errors: 0, Skipped: 24

NonHNS-SharedKey

[INFO] Results:
[INFO]
[INFO] Tests run: 88, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 440, Failures: 0, Errors: 0, Skipped: 243
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] ITestAbfsFileSystemContractRename>AbstractContractRenameTest.testRenameFileOverExistingFile:131->Assert.fail:88 expected rename(abfs://[email protected]/fork-4/test/source-256.txt, abfs://[email protected]/fork-4/test/dest-512.txt) to be rejected with exception, but got false
[INFO]
[ERROR] Tests run: 208, Failures: 1, Errors: 0, Skipped: 24

Rename Test failure is tracked in JIRA: https://issues.apache.org/jira/browse/HADOOP-17396

@hadoop-yetus

This comment has been minimized.

@steveloughran steveloughran merged commit cf43a7e into apache:trunk Nov 26, 2020
asfgit pushed a commit that referenced this pull request Nov 26, 2020
#2492)

Contributed by Sneha Vijayarajan.

Change-Id: I89c1061b1efb1e3bef019dd22f221d03bf015929
@steveloughran
Copy link
Contributor

+1, merged to branch-3.3+

jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
…ission update (apache#2492)

Contributed by Sneha Vijayarajan.

Backport Notes:

* This contains both branch-3.3 changes needed for this feature to work:
  PRs apache#2492 and apache#2504
* merge conflict in MockDelegationSASTokenProvider

Change-Id: I89c1061b1efb1e3bef019dd22f221d03bf015929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants