Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YARN-10488] - Several typos in package: org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair #2485

Merged
merged 1 commit into from
Nov 25, 2020
Merged

[YARN-10488] - Several typos in package: org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair #2485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .../main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@ public synchronized void recoverContainer(SchedulerNode node,
/**
* Reserve a spot for {@code container} on this {@code node}. If
* the container is {@code alreadyReserved} on the node, simply
* update relevant bookeeping. This dispatches ro relevant handlers
* update relevant bookkeeping. This dispatches ro relevant handlers
* in {@link FSSchedulerNode}..
* return whether reservation was possible with the current threshold limits
*/
Expand Down Expand Up @@ -1393,12 +1393,12 @@ private void updateAMDiagnosticMsg(Resource resource, String reason) {
return;
}

StringBuilder diagnosticMessageBldr = new StringBuilder();
diagnosticMessageBldr.append(" (Resource request: ")
StringBuilder diagnosticMessage = new StringBuilder();
diagnosticMessage.append(" (Resource request: ")
.append(resource)
.append(reason);
updateAMContainerDiagnostics(AMState.INACTIVATED,
diagnosticMessageBldr.toString());
diagnosticMessage.toString());
}

/*
Expand Down
2 changes: 1 addition & 1 deletion .../org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/MaxRunningAppsEnforcer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public void trackNonRunnableApp(FSAppAttempt app) {

/**
* This is called after reloading the allocation configuration when the
* scheduler is reinitilized
* scheduler is reinitialized
*
* Checks to see whether any non-runnable applications become runnable
* now that the max running apps of given queue has been changed
Expand Down
2 changes: 1 addition & 1 deletion .../main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ private void setChildResourceLimits(FSParentQueue parent, FSQueue child,
// Ad hoc queues do not exist in the configured queues map
if (!configuredQueues.get(FSQueueType.LEAF).contains(child.getName()) &&
!configuredQueues.get(FSQueueType.PARENT).contains(child.getName())) {
// For ad hoc queues, set their max reource allocations based on
// For ad hoc queues, set their max resource allocations based on
// their parents' default child settings.
ConfigurableResource maxChild = parent.getMaxChildQueueResource();

Expand Down
8 changes: 4 additions & 4 deletions ...ache/hadoop/yarn/server/resourcemanager/scheduler/fair/VisitedResourceRequestTracker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,11 @@ boolean visit(ResourceRequest rr) {

private class TrackerPerPriorityResource {
private Set<String> racksWithNodesVisited = new HashSet<>();
private Set<String> racksVisted = new HashSet<>();
private Set<String> racksVisited = new HashSet<>();
private boolean anyVisited;

private boolean visitAny() {
if (racksVisted.isEmpty() && racksWithNodesVisited.isEmpty()) {
if (racksVisited.isEmpty() && racksWithNodesVisited.isEmpty()) {
anyVisited = true;
}
return anyVisited;
Expand All @@ -91,13 +91,13 @@ private boolean visitRack(String rackName) {
if (anyVisited || racksWithNodesVisited.contains(rackName)) {
return false;
} else {
racksVisted.add(rackName);
racksVisited.add(rackName);
return true;
}
}

private boolean visitNode(String rackName) {
if (anyVisited || racksVisted.contains(rackName)) {
if (anyVisited || racksVisited.contains(rackName)) {
return false;
} else {
racksWithNodesVisited.add(rackName);
Expand Down
6 changes: 3 additions & 3 deletions ...p/yarn/server/resourcemanager/scheduler/fair/policies/DominantResourceFairnessPolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public void setFSContext(FSContext fsContext) {
* @return &lt; 0, 0, or &gt; 0 if the first item is less than, equal to,
* or greater than the second item, respectively
*/
protected int compareAttribrutes(Schedulable s1, Schedulable s2) {
protected int compareAttributes(Schedulable s1, Schedulable s2) {
int res = (int) Math.signum(s1.getStartTime() - s2.getStartTime());

if (res == 0) {
Expand Down Expand Up @@ -219,7 +219,7 @@ public int compare(Schedulable s1, Schedulable s2) {
}

if (res == 0) {
res = compareAttribrutes(s1, s2);
res = compareAttributes(s1, s2);
}

return res;
Expand Down Expand Up @@ -423,7 +423,7 @@ public int compare(Schedulable s1, Schedulable s2) {
}

if (res == 0) {
res = compareAttribrutes(s1, s2);
res = compareAttributes(s1, s2);
}

return res;
Expand Down