Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDFS-15529: getChildFilesystems should include fallback fs as well #2234

Merged
merged 3 commits into from
Sep 3, 2020
Merged

HDFS-15529: getChildFilesystems should include fallback fs as well #2234

merged 3 commits into from
Sep 3, 2020

Conversation

umamaheswararao
Copy link
Contributor

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 26m 12s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 3m 18s Maven dependency ordering for branch
-1 ❌ mvninstall 13m 36s root in trunk failed.
+1 💚 compile 22m 40s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 16m 59s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
-0 ⚠️ checkstyle 2m 22s The patch fails to run checkstyle in root
+1 💚 mvnsite 2m 57s trunk passed
+1 💚 shadedclient 19m 49s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 43s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 3m 14s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗 spotbugs 3m 13s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 24s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for patch
+1 💚 mvninstall 2m 0s the patch passed
+1 💚 compile 18m 56s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 18m 56s the patch passed
+1 💚 compile 16m 55s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 16m 55s the patch passed
-0 ⚠️ checkstyle 2m 17s The patch fails to run checkstyle in root
+1 💚 mvnsite 2m 56s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 15s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 41s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 3m 18s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 findbugs 5m 41s the patch passed
_ Other Tests _
+1 💚 unit 9m 20s hadoop-common in the patch passed.
-1 ❌ unit 99m 5s hadoop-hdfs in the patch passed.
+1 💚 asflicense 1m 8s The patch does not generate ASF License warnings.
296m 9s
Reason Tests
Failed junit tests hadoop.fs.viewfs.TestViewFileSystemLinkMergeSlash
hadoop.hdfs.TestFileChecksumCompositeCrc
hadoop.hdfs.server.namenode.ha.TestHAAppend
hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
hadoop.hdfs.TestDFSStripedInputStream
hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
hadoop.hdfs.TestErasureCodingPolicies
hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
hadoop.hdfs.TestStripedFileAppend
hadoop.hdfs.TestFileChecksum
hadoop.hdfs.qjournal.TestNNWithQJM
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/1/artifact/out/Dockerfile
GITHUB PR #2234
JIRA Issue HDFS-15529
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux e45cee4a54db 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / f734455
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
mvninstall https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/1/artifact/out/branch-mvninstall-root.txt
checkstyle https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/1/artifact/out/buildtool-branch-checkstyle-root.txt
checkstyle https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/1/artifact/out/buildtool-patch-checkstyle-root.txt
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/1/testReport/
Max. process+thread count 4368 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 57s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 3m 20s Maven dependency ordering for branch
+1 💚 mvninstall 33m 8s trunk passed
+1 💚 compile 22m 41s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 16m 54s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 checkstyle 2m 43s trunk passed
+1 💚 mvnsite 3m 0s trunk passed
+1 💚 shadedclient 20m 43s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 41s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 3m 10s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗 spotbugs 3m 12s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 23s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for patch
+1 💚 mvninstall 1m 57s the patch passed
+1 💚 compile 18m 49s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 18m 49s the patch passed
+1 💚 compile 17m 5s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 17m 5s the patch passed
-0 ⚠️ checkstyle 2m 40s root: The patch generated 1 new + 58 unchanged - 0 fixed = 59 total (was 58)
+1 💚 mvnsite 2m 56s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 23s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 39s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 3m 8s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 findbugs 5m 43s the patch passed
_ Other Tests _
+1 💚 unit 9m 28s hadoop-common in the patch passed.
-1 ❌ unit 120m 12s hadoop-hdfs in the patch passed.
-1 ❌ asflicense 1m 5s The patch generated 3 ASF License warnings.
314m 4s
Reason Tests
Failed junit tests hadoop.hdfs.TestFileChecksumCompositeCrc
hadoop.hdfs.TestFileChecksum
hadoop.hdfs.server.balancer.TestBalancer
hadoop.hdfs.server.datanode.TestBPOfferService
hadoop.hdfs.server.namenode.TestNameNodeMXBean
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/2/artifact/out/Dockerfile
GITHUB PR #2234
JIRA Issue HDFS-15529
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 26669b30df2c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 56a5c36
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
checkstyle https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/2/artifact/out/diff-checkstyle-root.txt
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/2/testReport/
asflicense https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/2/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 3832 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/2/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 3m 22s Maven dependency ordering for branch
+1 💚 mvninstall 26m 27s trunk passed
+1 💚 compile 19m 38s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 16m 58s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 checkstyle 2m 46s trunk passed
+1 💚 mvnsite 2m 59s trunk passed
+1 💚 shadedclient 20m 32s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 43s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 3m 19s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗 spotbugs 3m 11s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 22s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for patch
+1 💚 mvninstall 2m 1s the patch passed
+1 💚 compile 18m 47s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 18m 47s the patch passed
+1 💚 compile 17m 28s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 17m 28s the patch passed
+1 💚 checkstyle 2m 57s the patch passed
+1 💚 mvnsite 3m 5s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 13s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 41s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 3m 16s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 findbugs 5m 37s the patch passed
_ Other Tests _
+1 💚 unit 9m 24s hadoop-common in the patch passed.
-1 ❌ unit 99m 0s hadoop-hdfs in the patch passed.
+1 💚 asflicense 1m 15s The patch does not generate ASF License warnings.
282m 37s
Reason Tests
Failed junit tests hadoop.hdfs.TestFileChecksumCompositeCrc
hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
hadoop.hdfs.TestFileChecksum
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/3/artifact/out/Dockerfile
GITHUB PR #2234
JIRA Issue HDFS-15529
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux eb93209a8a11 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c7dab2b
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/3/testReport/
Max. process+thread count 4592 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2234/3/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

ayushtkn
ayushtkn approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx @umamaheswararao for the work here.
Changes LGTM.
*Test failures seems unrelated.

@umamaheswararao umamaheswararao merged commit b3660d0 into apache:trunk Sep 3, 2020
@umamaheswararao
Copy link
Contributor Author

Thanks @ayushtkn for the review.

umamaheswararao added a commit that referenced this pull request Sep 13, 2020
@umamaheswararao
HDFS-15529: getChildFilesystems should include fallback fs as well (#…
1195dac 
…2234). Contributed by Uma Maheswara Rao G.

(cherry picked from commit b3660d0)
@xinglin xinglin mentioned this pull request Apr 20, 2022
Merged
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@umamaheswararao
HDFS-15529: getChildFilesystems should include fallback fs as well (a…
7c5fba4 
…pache#2234). Contributed by Uma Maheswara Rao G.

(cherry picked from commit b3660d0)
Change-Id: Ib2f5789f65b4ab9a88eaa0b428937f0b1ab81d70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushtkn ayushtkn ayushtkn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umamaheswararao @hadoop-yetus @ayushtkn