Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-16869. Upgrade findbugs-maven-plugin to 3.0.5 to fix mvn findbugs:findbugs failure #1855

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

aajisaka
Copy link
Member

@aajisaka aajisaka requested a review from iwasakims February 20, 2020 02:45
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 24s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 33m 1s trunk passed
+1 💚 compile 0m 20s trunk passed
+1 💚 mvnsite 0m 21s trunk passed
+1 💚 shadedclient 54m 22s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 25s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 16s the patch passed
+1 💚 compile 0m 16s the patch passed
+1 💚 javac 0m 16s the patch passed
+1 💚 mvnsite 0m 21s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
-1 ❌ shadedclient 5m 22s patch has errors when building and testing our client artifacts.
+1 💚 javadoc 0m 16s the patch passed
_ Other Tests _
+1 💚 unit 0m 12s hadoop-project in the patch passed.
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
67m 10s
Subsystem Report/Notes
Docker Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1855/1/artifact/out/Dockerfile
GITHUB PR #1855
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname Linux b16ec2e4e5b0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / ec75071
Default Java 1.8.0_242
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1855/1/testReport/
Max. process+thread count 327 (vs. ulimit of 5500)
modules C: hadoop-project U: hadoop-project
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1855/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. It worked on both Maven 3.6.3 and 3.5.0. Thanks, @aajisaka.

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Jenkins reports error.
But nothing here :
https://builds.apache.org/job/hadoop-multibranch/job/PR-1855/1/artifact/out/branch-shadedclient.txt
Should be problem with the build, Do check once, before pushing.

+1

@aajisaka
Copy link
Member Author

The shaded client build error is not related the patch.
https://builds.apache.org/job/hadoop-multibranch/job/PR-1855/1/artifact/out/patch-shadedclient.txt

[ERROR] Failed to execute goal org.xolstice.maven.plugins:protobuf-maven-plugin:0.5.1:compile (src-compile-protoc) on project hadoop-mapreduce-client-common: An error occurred while invoking protoc. Error while executing process. Cannot run program "/home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1855/src/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/target/protoc-plugins/protoc-3.7.1-linux-x86_64.exe": error=11, Resource temporarily unavailable -> [Help 1]

Merging this. Thanks @iwasakims and @ayushtkn

@aajisaka aajisaka merged commit 7f35676 into apache:trunk Feb 21, 2020
@aajisaka aajisaka deleted the HADOOP-16869 branch February 21, 2020 03:22
aajisaka added a commit that referenced this pull request Feb 21, 2020
…ugs:findbugs failure (#1855)

(cherry picked from commit 7f35676)

 Conflicts:
	hadoop-project/pom.xml
aajisaka added a commit that referenced this pull request Feb 21, 2020
…ugs:findbugs failure (#1855)

(cherry picked from commit 7f35676)

 Conflicts:
	hadoop-project/pom.xml

(cherry picked from commit b52f201)
bilaharith pushed a commit to bilaharith/hadoop that referenced this pull request Mar 19, 2020
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
aajisaka added a commit that referenced this pull request Apr 13, 2020
…ugs:findbugs failure (#1855)

(cherry picked from commit 7f35676)

 Conflicts:
	hadoop-project/pom.xml
aajisaka added a commit that referenced this pull request Apr 13, 2020
…ugs:findbugs failure (#1855)

(cherry picked from commit 7f35676)

 Conflicts:
	hadoop-project/pom.xml

(cherry picked from commit 8fae3b1)
bentito pushed a commit to bentito/hadoop that referenced this pull request Dec 2, 2020
…ugs:findbugs failure (apache#1855)

(cherry picked from commit 7f35676)

 Conflicts:
	hadoop-project/pom.xml

(cherry picked from commit b52f201)
bentito pushed a commit to bentito/hadoop that referenced this pull request Dec 3, 2020
…ugs:findbugs failure (apache#1855)

(cherry picked from commit 7f35676)

 Conflicts:
	hadoop-project/pom.xml

(cherry picked from commit b52f201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants