Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YARN-10074. Update netty to 4.1.42Final in yarn-csi. Contributed by Wei-Chiu Chuang. #1807

Merged
merged 2 commits into from
Feb 25, 2020
Merged

YARN-10074. Update netty to 4.1.42Final in yarn-csi. Contributed by Wei-Chiu Chuang. #1807

merged 2 commits into from
Feb 25, 2020

Conversation

jojochuang
Copy link
Contributor

No description provided.

@jojochuang jojochuang requested a review from aajisaka January 15, 2020 19:21
@aajisaka
Copy link
Member

Hi @jojochuang ,

        <dependency>
            <groupId>io.netty</groupId>
            <artifactId>netty-all</artifactId>
            <version>${netty-all.version}</version>
        </dependency>

Can we remove the <version> tag? That way yarn-csi module will use the version which is defined by the dependencyManagement section of the pom.xml (hadoop-project module).

@jojochuang
YARN-10074. Update netty to 4.1.42Final in yarn-csi. Contributed by W…
e37c3ba 
…ei-Chiu Chuang.

Change-Id: I58fb7daf03e9e924f585bf3d25384cc800c621b3
@jojochuang
Use the netty version from the root pom.
6193c65 
Change-Id: I5f4ad9e117002865ff685db567d5789987234c07
@jojochuang
Copy link
Contributor Author

Sorry for late response. The updated PR is up here.

aajisaka
aajisaka approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you for the update.

@aajisaka
Copy link
Member

The precommit job timed out because the patch modifies LICENSE-binary, which is under the project root directory.
https://builds.apache.org/job/hadoop-multibranch/view/change-requests/job/PR-1807/lastBuild/

@aajisaka aajisaka merged commit dda00d3 into apache:trunk Feb 25, 2020
bilaharith pushed a commit to bilaharith/hadoop that referenced this pull request Mar 19, 2020
@jojochuang @bilaharith
YARN-10074. Update netty to 4.1.42Final in yarn-csi. Contributed by W…
9d63d09 
…ei-Chiu Chuang. (apache#1807)
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
@jojochuang @RogPodge
YARN-10074. Update netty to 4.1.42Final in yarn-csi. Contributed by W…
2552295 
…ei-Chiu Chuang. (apache#1807)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aajisaka aajisaka aajisaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jojochuang @aajisaka