-
Notifications
You must be signed in to change notification settings - Fork 8.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HADOOP-19047: Support InMemory Tracking Of S3A Magic Commits
- Loading branch information
1 parent
da34ecd
commit a5b27c5
Showing
12 changed files
with
577 additions
and
105 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
126 changes: 126 additions & 0 deletions
126
...p-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/magic/InMemoryMagicCommitTracker.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.fs.s3a.commit.magic; | ||
|
|
||
| import org.apache.commons.lang3.StringUtils; | ||
| import org.apache.hadoop.fs.Path; | ||
| import org.apache.hadoop.fs.s3a.WriteOperationHelper; | ||
| import org.apache.hadoop.fs.s3a.commit.files.SinglePendingCommit; | ||
| import org.apache.hadoop.fs.s3a.statistics.PutTrackerStatistics; | ||
| import org.apache.hadoop.fs.statistics.IOStatistics; | ||
| import org.apache.hadoop.fs.statistics.IOStatisticsSnapshot; | ||
| import org.apache.hadoop.thirdparty.com.google.common.base.Preconditions; | ||
| import software.amazon.awssdk.services.s3.model.CompletedPart; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.ArrayList; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.concurrent.ConcurrentHashMap; | ||
|
|
||
| import static org.apache.hadoop.fs.s3a.commit.magic.MagicCommitTrackerUtils.extractTaskAttemptIdFromPath; | ||
|
|
||
| /** | ||
| * InMemoryMagicCommitTracker stores the commit data in memory. | ||
| * The commit data and related data stores are flushed out from | ||
| * the memory when the task is committed or aborted. | ||
| */ | ||
| public class InMemoryMagicCommitTracker extends MagicCommitTracker { | ||
|
|
||
| // stores taskAttemptId to commit data mapping | ||
| private static Map<String, List<SinglePendingCommit>> | ||
| taskAttemptIdToMpuMetdadataMap = new ConcurrentHashMap<>(); | ||
|
|
||
| // stores the path to its length/size mapping | ||
| private static Map<Path, Long> taskAttemptIdToBytesWritten = new ConcurrentHashMap<>(); | ||
|
|
||
| // stores taskAttemptId to path mapping | ||
| private static Map<String, List<Path>> taskAttemptIdToPath = new ConcurrentHashMap<>(); | ||
|
|
||
| public InMemoryMagicCommitTracker(Path path, | ||
| String bucket, | ||
| String originalDestKey, | ||
| String destKey, | ||
| String pendingsetKey, | ||
| WriteOperationHelper writer, | ||
| PutTrackerStatistics trackerStatistics) { | ||
| super(path, bucket, originalDestKey, destKey, pendingsetKey, writer, trackerStatistics); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean aboutToComplete(String uploadId, | ||
| List<CompletedPart> parts, | ||
| long bytesWritten, | ||
| final IOStatistics iostatistics) | ||
| throws IOException { | ||
| Preconditions.checkArgument(StringUtils.isNotEmpty(uploadId), | ||
| "empty/null upload ID: " + uploadId); | ||
| Preconditions.checkArgument(parts != null, "No uploaded parts list"); | ||
| Preconditions.checkArgument(!parts.isEmpty(), "No uploaded parts to save"); | ||
|
|
||
| // build the commit summary | ||
| SinglePendingCommit commitData = new SinglePendingCommit(); | ||
| commitData.touch(System.currentTimeMillis()); | ||
| commitData.setDestinationKey(getDestKey()); | ||
| commitData.setBucket(getBucket()); | ||
| commitData.setUri(getPath().toUri().toString()); | ||
| commitData.setUploadId(uploadId); | ||
| commitData.setText(""); | ||
| commitData.setLength(bytesWritten); | ||
| commitData.bindCommitData(parts); | ||
| commitData.setIOStatistics(new IOStatisticsSnapshot(iostatistics)); | ||
|
|
||
| // extract the taskAttemptId from the path | ||
| String taskAttemptId = extractTaskAttemptIdFromPath(getPath()); | ||
|
|
||
| // store the commit data with taskAttemptId as the key | ||
| taskAttemptIdToMpuMetdadataMap.computeIfAbsent(taskAttemptId, | ||
| k -> Collections.synchronizedList(new ArrayList<>())).add(commitData); | ||
|
|
||
| // store the byteswritten(length) for the corresponding file | ||
| taskAttemptIdToBytesWritten.put(getPath(), bytesWritten); | ||
|
|
||
| // store the mapping between taskAttemptId and path | ||
| // This information is used for removing entries from | ||
| // the map once the taskAttempt is completed/committed. | ||
| taskAttemptIdToPath.computeIfAbsent(taskAttemptId, | ||
| k -> Collections.synchronizedList(new ArrayList<>())).add(getPath()); | ||
|
|
||
| LOG.info("commit metadata for {} parts in {}. size: {} byte(s) " | ||
| + "for the taskAttemptId: {} is stored in memory", | ||
| parts.size(), getPendingPartKey(), bytesWritten, taskAttemptId); | ||
| LOG.debug("Closed MPU to {}, saved commit information to {}; data=:\n{}", | ||
| getPath(), getPendingPartKey(), commitData); | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| public static Map<String, List<SinglePendingCommit>> getTaskAttemptIdToMpuMetdadataMap() { | ||
| return taskAttemptIdToMpuMetdadataMap; | ||
| } | ||
|
|
||
| public static Map<Path, Long> getTaskAttemptIdToBytesWritten() { | ||
| return taskAttemptIdToBytesWritten; | ||
| } | ||
|
|
||
| public static Map<String, List<Path>> getTaskAttemptIdToPath() { | ||
| return taskAttemptIdToPath; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.