Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#950] improvment(common): Add a method in ConfigEntry to support configurations with no default value #996

Closed
wants to merge 1 commit into from

Conversation

qqqttt123
Copy link
Contributor

@qqqttt123 qqqttt123 commented Dec 6, 2023

What changes were proposed in this pull request?

Some configuration options are necessary but don't have default value.

Why are the changes needed?

Fix: #950

Does this PR introduce any user-facing change?

Change some configuration options from `` to none

How was this patch tested?

CI passed.

…to support configurations with no default value
@jerryshao
Copy link
Contributor

I will defer this to 0.4

@qqqttt123 qqqttt123 changed the title [#950] improvment(common): Add a method in ConfigEntry called create to support configurations with no default value [#950] improvment(common): Add a method in ConfigEntry to support configurations with no default value Dec 6, 2023
@qqqttt123
Copy link
Contributor Author

I will defer this to 0.4

Ok.

Copy link

github-actions bot commented Dec 6, 2023

Code Coverage Report

Overall Project 65.79% -0.06% 🟢
Files changed 35.85% 🔴

Module Coverage
server-common 67.14% 🟢
common 41.95% -0.27% 🔴
Files
Module File Coverage
server-common OAuthConfig.java 100% 🟢
JettyServerConfig.java 92.66% 🟢
common ConfigEntry.java 78.8% -13.6% 🔴

@jerryshao jerryshao closed this Dec 13, 2023
@qqqttt123 qqqttt123 closed this by deleting the head repository Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Add a method in ConfigEntry called create to support configurations with no default value
2 participants