[MINOR] docs: correct credential vending document #6248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
changed the title
|
@jerryshao @yuqi1129 PTAL |
yuqi1129
reviewed
Jan 15, 2025
| @@ -53,6 +53,7 @@ An S3 token is a token credential with scoped privileges, by leveraging STS [Ass | |||
| | `s3-access-key-id` | `gravitino.iceberg-rest.s3-access-key-id` | The static access key ID used to access S3 data. | (none) | Yes | 0.6.0-incubating | | |||
| | `s3-secret-access-key` | `gravitino.iceberg-rest.s3-secret-access-key` | The static secret access key used to access S3 data. | (none) | Yes | 0.6.0-incubating | | |||
| | `s3-role-arn` | `gravitino.iceberg-rest.s3-role-arn` | The ARN of the role to access the S3 data. | (none) | Yes | 0.7.0-incubating | | |||
| | `s3-region` | `gravitino.iceberg-rest.s3-region` | The region of the S3 service, like `us-west-2`. | (none) | No | 0.6.0-incubating | | |||
There was a problem hiding this comment.
Is the region required to provide credential service? Can it be replaced with the endpoint?
There was a problem hiding this comment.
region is an optional properties to get credential, there is another configuration for STS endpoint
yuqi1129
approved these changes
Jan 16, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
### What changes were proposed in this pull request? correct some mistakes for credential vending document ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? just document
jerqi
pushed a commit
that referenced
this pull request
Jan 23, 2025
### What changes were proposed in this pull request? correct some mistakes for credential vending document ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? just document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
correct some mistakes for credential vending document
Does this PR introduce any user-facing change?
no
How was this patch tested?
just document