Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6196] feat(iceberg): adjust table distribution if creating table without specifying disribution mode #6214

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FANNG1
Copy link
Contributor

@FANNG1 FANNG1 commented Jan 13, 2025

What changes were proposed in this pull request?

Adjust the distribution mode for creating Iceberg table with none distribution. the following is the Spark adjust logic, the flink is similar.

  private DistributionMode defaultWriteDistributionMode() {
    if (table.sortOrder().isSorted()) {
      return RANGE;
    } else if (table.spec().isPartitioned()) {
      return HASH;
    } else {
      return NONE;
    }
  }

Why are the changes needed?

Fix: #6196

Does this PR introduce any user-facing change?

Yes, add document

How was this patch tested?

add UT and IT

@FANNG1 FANNG1 marked this pull request as draft January 13, 2025 11:23
@FANNG1 FANNG1 changed the title [#6196] feat(iceberg): adjust distribution if creating table with none disribution. [#6196] feat(iceberg): adjust distribution if creating table without specifying disribution mode Jan 13, 2025
@FANNG1 FANNG1 changed the title [#6196] feat(iceberg): adjust distribution if creating table without specifying disribution mode [#6196] feat(iceberg): adjust table distribution if creating table without specifying disribution mode Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] correct the behaviors when creating Iceberg table with none distribution
1 participant