[#5100] improvement(docs): Add extra documents to clarify the engine type of MySQL catalog #6209
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
reviewed
Jan 13, 2025
docs/jdbc-mysql-catalog.md
Outdated
| @@ -186,6 +186,12 @@ Although MySQL itself does not support table properties, Gravitino offers table | |||
| | `engine` | The engine used by the table. For example `MyISAM`, `MEMORY`, `CSV`, `ARCHIVE`, `BLACKHOLE`, `FEDERATED`, `ndbinfo`, `MRG_MYISAM`, `PERFORMANCE_SCHEMA`. | `InnoDB` | No | No | Yes | 0.4.0 | | |||
| | `auto-increment-offset` | Used to specify the starting value of the auto-increment field. | (none) | No | No | Yes | 0.4.0 | | |||
|
|
|||
| :::note | |||
| Some engine types may not be supported by MySQL by default and required additional configuration. For instance, `FEDERATED` are not supported by | |||
There was a problem hiding this comment.
"...and require additional configurations."
jerryshao
reviewed
Jan 13, 2025
docs/jdbc-mysql-catalog.md
Outdated
| @@ -186,6 +186,12 @@ Although MySQL itself does not support table properties, Gravitino offers table | |||
| | `engine` | The engine used by the table. For example `MyISAM`, `MEMORY`, `CSV`, `ARCHIVE`, `BLACKHOLE`, `FEDERATED`, `ndbinfo`, `MRG_MYISAM`, `PERFORMANCE_SCHEMA`. | `InnoDB` | No | No | Yes | 0.4.0 | | |||
| | `auto-increment-offset` | Used to specify the starting value of the auto-increment field. | (none) | No | No | Yes | 0.4.0 | | |||
|
|
|||
| :::note | |||
| Some engine types may not be supported by MySQL by default and require additional configuration. For instance, `FEDERATED` are not supported by | |||
There was a problem hiding this comment.
“configurations”, not "configuration".
jerryshao
approved these changes
Jan 13, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
…type of MySQL catalog (#6209) ### What changes were proposed in this pull request? Add more details about the usage of engine type for MySQL catalog. ### Why are the changes needed? The value of engine type may be influenced by many factors like MySQL version, configurations and so on, we need to clarify it. Fix: #5100 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Jan 14, 2025
…ngine type of MySQL catalog (apache#6209) ### What changes were proposed in this pull request? Add more details about the usage of engine type for MySQL catalog. ### Why are the changes needed? The value of engine type may be influenced by many factors like MySQL version, configurations and so on, we need to clarify it. Fix: apache#5100 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add more details about the usage of engine type for MySQL catalog.
Why are the changes needed?
The value of engine type may be influenced by many factors like MySQL version, configurations and so on, we need to clarify it.
Fix: #5100
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
N/A