[#6200] improvement(docs): Add Docker image details for 0.8.0 #6202
Conversation
docs/docker-image-details.md
Outdated
| - apache/gravitino:0.8.0-incubating | ||
| - Based on Gravitino 0.8.0-incubating, you can know more information from 0.8.0-incubating [release notes](https://github.com/apache/gravitino/releases/tag/v0.8.0-incubating). | ||
|
|
||
|
|
There was a problem hiding this comment.
Please remove this redundant line.
There was a problem hiding this comment.
We should use two blank lines here.
There was a problem hiding this comment.
Previously, I wanted to point this out because I noticed the newly added lines are somewhat different from the others.
There was a problem hiding this comment.
Em... I could keep the same style with others. I remember I used two blank lines before.
docs/docker-image-details.md
Outdated
| @@ -60,6 +64,10 @@ docker run --rm -d -p 9001:9001 apache/gravitino-iceberg-rest:0.7.0-incubating | |||
|
|
|||
| Changelog | |||
|
|
|||
|
|
|||
| - apache/gravitino-iceberg-rest:0.8.0-incubating | |||
| - Based on Gravitino 0.8.0-incubating, you can know more information from 0.8.0-incubating release notes. | |||
There was a problem hiding this comment.
I think we could also add the URL here, including the one for version 0.6.0.
There was a problem hiding this comment.
Removed. According to Fanng's suggestion.
docs/docker-image-details.md
Outdated
| - apache/gravitino-playground:trino-435-gravitino-0.8.0-incubating | ||
| - Use Gravitino release 0.8.0-incubating Dockerfile to build the image. | ||
|
|
||
|
|
There was a problem hiding this comment.
Only one blank line should be between items.
There was a problem hiding this comment.
We should use two blank lines here otherwise style will be weird.
|
LGTM, @jerryshao @diqiu50 do you have time to review again? |
### What changes were proposed in this pull request? Add Docker image details for 0.8.0 ### Why are the changes needed? Fix: #6200 ### Does this PR introduce _any_ user-facing change? Add doc. ### How was this patch tested? No need.
…pache#6202) ### What changes were proposed in this pull request? Add Docker image details for 0.8.0 ### Why are the changes needed? Fix: apache#6200 ### Does this PR introduce _any_ user-facing change? Add doc. ### How was this patch tested? No need.
What changes were proposed in this pull request?
Add Docker image details for 0.8.0
Why are the changes needed?
Fix: #6200
Does this PR introduce any user-facing change?
Add doc.
How was this patch tested?
No need.