Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5545] fix(doris-catalog): Fix the problem that we can't set Doris table properties. #6186

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

yuqi1129
Copy link
Contributor

What changes were proposed in this pull request?

Modify table properties SQL in alter table sentence to support setting table properties.

Why are the changes needed?

It's a bug.

Fix: #5545

Does this PR introduce any user-facing change?

N/A.

How was this patch tested?

IT.

@yuqi1129 yuqi1129 self-assigned this Jan 10, 2025
@yuqi1129 yuqi1129 added the branch-0.8 Automatically cherry-pick commit to branch-0.8 label Jan 10, 2025
if (!setProperties.isEmpty()) {
alterSql.add(generateTableProperties(setProperties));
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jerryshao jerryshao requested a review from mchades January 13, 2025 06:51
@jerryshao
Copy link
Contributor

@mchades can you please help to review this?

Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mchades mchades merged commit d32af61 into apache:main Jan 13, 2025
28 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
…able properties. (#6186)

### What changes were proposed in this pull request?

Modify table properties SQL in alter table sentence to support setting
table properties.

### Why are the changes needed?

It's a bug.

Fix: #5545

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

IT.
Abyss-lord pushed a commit to Abyss-lord/gravitino that referenced this pull request Jan 14, 2025
…oris table properties. (apache#6186)

### What changes were proposed in this pull request?

Modify table properties SQL in alter table sentence to support setting
table properties.

### Why are the changes needed?

It's a bug.

Fix: apache#5545

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

IT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-0.8 Automatically cherry-pick commit to branch-0.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] Failed to set property for doris table
4 participants