Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6151] improve(CLI): Refactor group commands in Gavitino CLI #6175

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Abyss-lord
Copy link
Contributor

What changes were proposed in this pull request?

Refactor group commands in Gavitino CLI.

Why are the changes needed?

Fix: #6151

Does this PR introduce any user-facing change?

No

How was this patch tested?

local test.

@Abyss-lord
Copy link
Contributor Author

Hi @justinmclean @tengqm , could you please review this PR when you have time? I’d really appreciate your feedback.

Copy link
Member

@justinmclean justinmclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@justinmclean justinmclean merged commit 20bfeba into apache:main Jan 10, 2025
27 checks passed
@Abyss-lord Abyss-lord deleted the refactor-group-command branch January 10, 2025 07:12
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this pull request Jan 11, 2025
…pache#6175)

### What changes were proposed in this pull request?

Refactor group commands in Gavitino CLI.

### Why are the changes needed?

Fix: apache#6151 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor group commands in Gavitino CLI
2 participants