[#6153]refactor: Break up role commands in Gravitino CLI #6170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmclean
changed the title
justinmclean
reviewed
Jan 9, 2025
| return false; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
All calls below are misisng calls to validate()
justinmclean
reviewed
Jan 9, 2025
| command + " requires exactly one role, but multiple are currently passed."); | ||
| return roles[0]; | ||
| } | ||
| } |
There was a problem hiding this comment.
Please don't change error messages, as they need to be consistent with other error messages.
justinmclean
reviewed
Jan 9, 2025
|
|
||
| metalake = new FullName(line).getMetalakeName(); | ||
|
|
||
| String[] roles = line.getOptionValues(GravitinoOptions.ROLE); |
There was a problem hiding this comment.
roles could become a property
justinmclean
reviewed
Jan 9, 2025
| roles = Arrays.stream(roles).distinct().toArray(String[]::new); | ||
| } | ||
|
|
||
| String[] privileges = line.getOptionValues(GravitinoOptions.PRIVILEGE); |
justinmclean
reviewed
Jan 9, 2025
There was a problem hiding this comment.
This file is missing a license header, causing the CI to fail.
…ne class Break up role commands in Gravitino command line class For readability and maintainability. Tested locally.
cool9850311
force-pushed
the
ISSUE-6153
branch
from
79ec945 to
3a673f0
Compare
justinmclean
approved these changes
Jan 10, 2025
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Jan 11, 2025
…e#6170) ### What changes were proposed in this pull request? Break up role commands in Gravitino command line class ### Why are the changes needed? For readability and maintainability. ### Fix: apache#6153 ### Does this PR introduce any user-facing change? None. ### How was this patch tested? Tested locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Break up role commands in Gravitino command line class
Why are the changes needed?
For readability and maintainability.
Fix: #6153
Does this PR introduce any user-facing change?
None.
How was this patch tested?
Tested locally.