[#6143] improve(CLI): Refactor catalog commands in Gavitino CLI #6159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Refactor catalog commands in Gavitino CLI and Base class. 2. Add test case.
|
Hi @justinmclean @tengqm , could you please review this PR when you have time? I’d really appreciate your feedback. |
justinmclean
reviewed
Jan 9, 2025
clients/cli/src/main/java/org/apache/gravitino/cli/CatalogCommandHandler.java
Outdated
Show resolved
Hide resolved
justinmclean
reviewed
Jan 9, 2025
clients/cli/src/test/java/org/apache/gravitino/cli/TestCommandHandler.java
Outdated
Show resolved
Hide resolved
|
Hi @justinmclean , I’ve finished updating the code. Please take a look at the PR again when you have time. |
Abyss-lord
added a commit
to Abyss-lord/gravitino
that referenced
this pull request
Jan 10, 2025
…apache#6159) ### What changes were proposed in this pull request? 1. Refactor catalog commands and Base class in Gavitino CLI. 2. Add test case. ### Why are the changes needed? Fix: apache#6143 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? local test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #6143
Does this PR introduce any user-facing change?
No
How was this patch tested?
local test.