[#5192] [#5193] feat(flink): Support Catalog&Schema Operation DDL for paimon-catalog #5818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coolderli Please have a look |
coolderli
reviewed
Dec 12, 2024
.../java/org/apache/gravitino/flink/connector/integration/test/paimon/FlinkPaimonCatalogIT.java
Outdated
Show resolved
Hide resolved
...or/flink/src/main/java/org/apache/gravitino/flink/connector/store/GravitinoCatalogStore.java
Outdated
Show resolved
Hide resolved
...ink/src/main/java/org/apache/gravitino/flink/connector/paimon/PaimonPropertiesConverter.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Dec 17, 2024
.../java/org/apache/gravitino/flink/connector/integration/test/paimon/FlinkPaimonCatalogIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Dec 17, 2024
...ink/src/main/java/org/apache/gravitino/flink/connector/paimon/PaimonPropertiesConverter.java
Show resolved
Hide resolved
|
@hdygxsj could you rebase your code? |
Done，PHAL |
|
@sunxiaojian do you have time to review this PR? |
FANNG1
reviewed
Dec 20, 2024
.../java/org/apache/gravitino/flink/connector/integration/test/paimon/FlinkPaimonCatalogIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Dec 20, 2024
.../java/org/apache/gravitino/flink/connector/integration/test/paimon/FlinkPaimonCatalogIT.java
Outdated
Show resolved
Hide resolved
|
Is there anything else that needs to be fixed @FANNG1 |
Sorry, I'm working on the issues to release 0.8, may doesn't have enough time to review this PR these days. |
|
look good for me !! i need it ! ! |
FANNG1
reviewed
Jan 10, 2025
...ink/src/main/java/org/apache/gravitino/flink/connector/paimon/PaimonPropertiesConverter.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 10, 2025
FANNG1
reviewed
Jan 13, 2025
...ink/src/main/java/org/apache/gravitino/flink/connector/paimon/PaimonPropertiesConverter.java
Show resolved
Hide resolved
...mon/src/main/java/org/apache/gravitino/spark/connector/paimon/PaimonPropertiesConverter.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/gravitino/flink/connector/integration/test/paimon/FlinkPaimonCatalogIT.java
Outdated
Show resolved
Hide resolved
...flink/src/test/java/org/apache/gravitino/flink/connector/integration/test/FlinkCommonIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 13, 2025
...flink/src/test/java/org/apache/gravitino/flink/connector/integration/test/FlinkCommonIT.java
Outdated
Show resolved
Hide resolved
|
LGTM, except minor comments. |
FANNG1
approved these changes
Jan 13, 2025
FANNG1
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
… paimon-catalog (#5818) ### What changes were proposed in this pull request? Support Catalog Operation DDL for paimon-catalog ### Why are the changes needed? Fix #5192 #5193 ### Does this PR introduce _any_ user-facing change? None ### How was this patch tested? org.apache.gravitino.flink.connector.paimon.TestPaimonPropertiesConverter org.apache.gravitino.flink.connector.integration.test.paimon.FlinkPaimonCatalogIT
|
@hdygxsj merged to main, thanks for your contribution, could you split more sub-tasks to support Flink paimon catalogs, so the other community member could join too. And would you mind add corresponding document about the Flink Paimon catalog? |
#6216 |
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Jan 14, 2025
…tion DDL for paimon-catalog (apache#5818) ### What changes were proposed in this pull request? Support Catalog Operation DDL for paimon-catalog ### Why are the changes needed? Fix apache#5192 apache#5193 ### Does this PR introduce _any_ user-facing change? None ### How was this patch tested? org.apache.gravitino.flink.connector.paimon.TestPaimonPropertiesConverter org.apache.gravitino.flink.connector.integration.test.paimon.FlinkPaimonCatalogIT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support Catalog Operation DDL for paimon-catalog
Why are the changes needed?
Fix #5192 #5193
Does this PR introduce any user-facing change?
None
How was this patch tested?
org.apache.gravitino.flink.connector.paimon.TestPaimonPropertiesConverter
org.apache.gravitino.flink.connector.integration.test.paimon.FlinkPaimonCatalogIT