(#4871)fix(test): Fix the jvm args -Xmx4G of gradle test can be overwrite by the extraJvmArgs.
#4872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchades
reviewed
Sep 6, 2024
| @@ -431,9 +431,9 @@ subprojects { | |||
| reports.html.outputLocation.set(file("${rootProject.projectDir}/build/reports/")) | |||
| val skipTests = project.hasProperty("skipTests") | |||
| if (!skipTests) { | |||
| jvmArgs = listOf("-Xmx4G") | |||
| val extraArgs = project.property("extraJvmArgs") as List<String> | |||
| jvmArgs = listOf("-Xmx4G") + extraArgs | |||
There was a problem hiding this comment.
Can you provide relevant screenshots to prove that this parameter actually works?
There was a problem hiding this comment.
Should this be backported to branch-0.6?
jerryshao
approved these changes
Sep 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 8, 2024
…rwrite by the `extraJvmArgs`. (#4872) ### What changes were proposed in this pull request? Fix the oom error when run the gradle test. ### Why are the changes needed? Fix: #4871 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually Co-authored-by: Jerry Shao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the oom error when run the gradle test.
Why are the changes needed?
Fix: #4871
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually