[MINOR] improvement: Remove the confusing comment #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
reviewed
May 30, 2024
| * `AddGroup` means that a role or user enters an organization. | ||
| * UserGroupManager is used for add, remove and get users or groups from one metalake. Metalake is | ||
| * like a concept of the organization. `AddUser` or `AddGroup` means that a user or group enters an | ||
| * organization. |
There was a problem hiding this comment.
* UserGroupManager is used for adding, removing, and getting users or groups to and from one metalake. Metalake is
* like a concept of the organization. `AddUser` or `AddGroup` means that a user or group enters an
* organization.
jerryshao
approved these changes
May 31, 2024
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
### What changes were proposed in this pull request? Remove the confusing comment. ### Why are the changes needed? Just a minor. ### Does this PR introduce _any_ user-facing change? No need. ### How was this patch tested? No need. --------- Co-authored-by: Heng Qin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the confusing comment.
Why are the changes needed?
Just a minor.
Does this PR introduce any user-facing change?
No need.
How was this patch tested?
No need.