Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3558] fix(client-python): specified tests packages version #3559

Merged
merged 1 commit into from
May 29, 2024

Conversation

featherchen
Copy link
Member

@featherchen featherchen commented May 24, 2024

What changes were proposed in this pull request?

As title, specify pylint version in order to avoid unexpected bugs in the future development.

Why are the changes needed?

Fix: #3558

Does this PR introduce any user-facing change?

No.

How was this patch tested?

./gradlew build -x test or ./gradlew :clients:client-python:pylint for for the convenience.

@featherchen
Copy link
Member Author

@noidname01 maybe you could help me check with this?

@noidname01
Copy link
Collaborator

noidname01 commented May 25, 2024

@featherchen Thank you for mentioning this. The pylint2 has different config file parser with pylint3, so it's important that we stick to specific version. Maybe you can help to lock other modules version?

@featherchen
Copy link
Member Author

featherchen commented May 27, 2024

@featherchen Thank you for mentioning this. The pylint2 has different config file parser with pylint3, so it's important that we stick to specific version. Maybe you can help to lock other modules version?

@noidname01 Sure, I've specified the version based on the CI in #3545, and I have also tested them on local machine. The process of gradle build should works properly now.

Screenshot from 2024-05-27 17-54-11

@noidname01
Copy link
Collaborator

@featherchen LGTM, Thanks

@featherchen featherchen changed the title [#3558] fix(client-python): specified pylint version to 3.1.0 [#3558] fix(client-python): specified tests packages version May 28, 2024
@jerryshao
Copy link
Contributor

LGTM.

@jerryshao jerryshao merged commit 63592af into apache:main May 29, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request May 29, 2024
### What changes were proposed in this pull request?

As title, specify pylint version in order to avoid unexpected bugs in
the future development.

### Why are the changes needed?

Fix: #3558

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

`./gradlew build -x test` or `./gradlew :clients:client-python:pylint`
for for the convenience.
diqiu50 pushed a commit to diqiu50/gravitino that referenced this pull request Jun 13, 2024
…pache#3559)

### What changes were proposed in this pull request?

As title, specify pylint version in order to avoid unexpected bugs in
the future development.

### Why are the changes needed?

Fix: apache#3558

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

`./gradlew build -x test` or `./gradlew :clients:client-python:pylint`
for for the convenience.
coolderli pushed a commit that referenced this pull request Dec 17, 2024
### What changes were proposed in this pull request?

As title, specify pylint version in order to avoid unexpected bugs in
the future development.

### Why are the changes needed?

Fix: #3558

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

`./gradlew build -x test` or `./gradlew :clients:client-python:pylint`
for for the convenience.

(cherry picked from commit 63592af)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] Unspecified pylint version in client-python
3 participants