[#3521] fix(client-python): Fix hash() function with multiple variables issue in name_identitifer
#3522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xunliu Could you take a look of this? Thanks. |
xloya
changed the title
hash() function in name_identitiferhash() function with multiple variables issue in name_identitifer
xunliu
reviewed
May 23, 2024
| ) | ||
| identifier_dict = {name_identifier1: "test1", name_identifier2: "test2"} | ||
|
|
||
| self.assertEqual("test1", identifier_dict.get(name_identifier1)) |
There was a problem hiding this comment.
I guess we could also add a assertNotEqual("test2", identifier_dict.get(name_identifier1))) in the use case?
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2024
…bles issue in `name_identitifer` (#3522) ### What changes were proposed in this pull request? Fix `hash()` function in `name_identifier`. ### Why are the changes needed? Fix: #3521 ### How was this patch tested? Add a ut. --------- Co-authored-by: xiaojiebao <[email protected]>
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
… variables issue in `name_identitifer` (apache#3522) ### What changes were proposed in this pull request? Fix `hash()` function in `name_identifier`. ### Why are the changes needed? Fix: apache#3521 ### How was this patch tested? Add a ut. --------- Co-authored-by: xiaojiebao <[email protected]>
coolderli
pushed a commit
that referenced
this pull request
Dec 17, 2024
…bles issue in `name_identitifer` (#3522) ### What changes were proposed in this pull request? Fix `hash()` function in `name_identifier`. ### Why are the changes needed? Fix: #3521 ### How was this patch tested? Add a ut. --------- Co-authored-by: xiaojiebao <[email protected]> (cherry picked from commit 1bb5f62)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix
hash()function inname_identifier.Why are the changes needed?
Fix: #3521
How was this patch tested?
Add a ut.