[#2883] refactor(ITUtils): move assertion functions from AbstractIT for clarity #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuqi1129 would you please help to review? Thanks. |
mchades
reviewed
Apr 12, 2024
| @@ -53,5 +65,62 @@ public static void overwriteConfigFile(String configFileName, Properties props) | |||
| } | |||
| } | |||
|
|
|||
| public static void assertionsTableInfo( | |||
There was a problem hiding this comment.
Can Hive IT and Iceberg IT also reuse this util method?
There was a problem hiding this comment.
The current content of the function assertionsTableInfo in CatalogHiveIT and CatalogIcebergIT differs from that in ITUtils; therefore, I don't think it can be reused.
|
Verified and it's okay with me. |
|
Merging to main, thanks @laiyousin for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move the two utility-oriented functions, assertionsTableInfo and assertColumn, from AbstractIT.java to ITUtils.java, and make them public.
Update all references to these functions accordingly.
Why are the changes needed?
Currently, the AbstractIT class in the Gravitino project contains two functions, assertionsTableInfo and assertColumn, which are more utility-oriented rather than integral to the abstract test class itself.
Fix: #2883
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
N/A