[#2164][#2166] improvement: enable MutablePublicArray and ReferenceEquality error-prone #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ReferenceEquality error-prone
|
@yuqi1129 @qqqttt123 Could you please help review this? Thanks. |
qqqttt123
reviewed
Mar 12, 2024
| @@ -649,4 +649,11 @@ void testDeadLockChecker() throws InterruptedException, ExecutionException { | |||
| service.take().get(); | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| public void testMockRootTreeLock() { | |||
There was a problem hiding this comment.
Why do we need to add this test case?
There was a problem hiding this comment.
@qqqttt123 I can remove it. I add it to validate https://github.com/datastrato/gravitino/pull/2511/files#diff-2144813a8300501a572d32e9f24651ab50594709644c031e983ac05a38bdc519R233.
if we replace == with .equals(), this unit test will failed. Do you think we need this?
qqqttt123
approved these changes
Mar 12, 2024
|
Thanks @coolderli @yuqi1129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
MutablePublicArrayaims to avoidpublic static final List<T>, because it can be modified outside. See more details at https://errorprone.info/bugpattern/MutablePublicArray.There are two ways to fix this problem:
Since
MutablePublicArrayhas been fixed at #2171, we enable the check in this MR.ReferenceEqualityaims to use reference equality instead of value equality for reference objects.There are some ways to fix this problem:
.equals()instead of==Objects.equals()if there is anullSee more details at https://errorprone.info/bugpattern/ReferenceEquality.
In this MR, we suppress this check at
com.datastrato.gravitino.catalog.lakehouse.iceberg.converter.ToIcebergType#structandcom.datastrato.gravitino.lock.LockManager#createTreeLock. In there places, we'd better use reference to compare the root node.Why are the changes needed?
Fix: [Improvement] JdbcConnectorUtils.java contains mutable array #2164
Fix: [Improvement] LockManager.java comparison using reference equality instead of value equality #2166
Does this PR introduce any user-facing change?
How was this patch tested?
./gradlew build