[#1758] feat(autoIncrement) : ColumnChange support auto_increment. #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearvive
force-pushed
the
1758/add-autoincrment-change
branch
from
d5512b5 to
d10a242
Compare
FANNG1
reviewed
Feb 29, 2024
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Show resolved
Hide resolved
FANNG1
reviewed
Feb 29, 2024
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Show resolved
Hide resolved
FANNG1
reviewed
Feb 29, 2024
.../main/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/ops/IcebergTableOpsHelper.java
Show resolved
Hide resolved
FANNG1
reviewed
Feb 29, 2024
.../catalog-hive/src/main/java/com/datastrato/gravitino/catalog/hive/HiveCatalogOperations.java
Show resolved
Hide resolved
|
@mchades please help to review |
Clearvive
force-pushed
the
1758/add-autoincrment-change
branch
from
65df07b to
21ae4f9
Compare
FANNG1
reviewed
Feb 29, 2024
api/src/main/java/com/datastrato/gravitino/rel/TableChange.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Feb 29, 2024
...c/test/java/com/datastrato/gravitino/integration/test/catalog/jdbc/mysql/CatalogMysqlIT.java
Outdated
Show resolved
Hide resolved
mchades
reviewed
Feb 29, 2024
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Show resolved
Hide resolved
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Show resolved
Hide resolved
Clearvive
force-pushed
the
1758/add-autoincrment-change
branch
from
e0500a5 to
abd3232
Compare
I don't think it's necessary to add this part anymore, it's all thrown out with exceptions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ColumnChange support auto_increment.
Including
AddColumnandUpdateColumnAutoIncrementWhy are the changes needed?
Fix: #1758
Does this PR introduce any user-facing change?
Add tableChange
How was this patch tested?
UT+IT