[#1590] docs: Add doc for column default value #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchades
force-pushed
the
doc-default-value
branch
2 times, most recently
from
934d5ca to
097fdcb
Compare
mchades
force-pushed
the
doc-default-value
branch
from
097fdcb to
281d658
Compare
jerryshao
reviewed
Feb 3, 2024
|
|
||
| :::note | ||
| When Gravitino loads a table from a catalog that supports default value, if Gravitino is unable to parse the default value, it will use an [Unparsed Expression](./expression.md#unparsed-expression) to preserve the original default value, ensuring that the table can be loaded successfully. | ||
| ::: |
There was a problem hiding this comment.
I think you should list some of the expressions you supported for column default value. Also point the "unparsed-expression" for others you don't support.
There was a problem hiding this comment.
Also update the case to add default value support here.
yuqi1129
reviewed
Feb 4, 2024
jerryshao
reviewed
Feb 4, 2024
mchades
force-pushed
the
doc-default-value
branch
from
281d658 to
cc147ff
Compare
jerryshao
reviewed
Feb 4, 2024
jerryshao
reviewed
Feb 4, 2024
jerryshao
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add doc for column default value
Why are the changes needed?
Fix: #1590
Does this PR introduce any user-facing change?
no
How was this patch tested?
no need