[#1707] feat(mysql): Support mysql index. #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearvive
force-pushed
the
1707/support-mysql-index
branch
from
cec9b63 to
d44ab8b
Compare
FANNG1
reviewed
Jan 26, 2024
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 26, 2024
| * @param fieldNames T. | ||
| * @return The primary key index | ||
| */ | ||
| public static Index createMysqlPrimaryKey(String[][] fieldNames) { |
There was a problem hiding this comment.
It's odd to add a method here, especally createMysqlPrimaryKey only used for test
There was a problem hiding this comment.
Okay, I plan to change the name to not a mandatory field
There was a problem hiding this comment.
Please address the comment here.
There was a problem hiding this comment.
If mysql doesn't support specify the key name, why don't you either ignore the key name or throw the exception, instead of adding a method here?
There was a problem hiding this comment.
The code will throw an exception. This is just an API utility class.
FANNG1
reviewed
Jan 26, 2024
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 26, 2024
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Show resolved
Hide resolved
FANNG1
reviewed
Jan 26, 2024
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 26, 2024
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Show resolved
Hide resolved
FANNG1
reviewed
Jan 26, 2024
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 26, 2024
FANNG1
reviewed
Jan 26, 2024
server/src/test/java/com/datastrato/gravitino/server/web/rest/TestTableOperations.java
Show resolved
Hide resolved
FANNG1
reviewed
Jan 26, 2024
common/src/main/java/com/datastrato/gravitino/dto/requests/TableCreateRequest.java
Show resolved
Hide resolved
Clearvive
force-pushed
the
1707/support-mysql-index
branch
3 times, most recently
from
b86d424 to
413a257
Compare
mchades
reviewed
Jan 26, 2024
mchades
reviewed
Jan 26, 2024
common/src/main/java/com/datastrato/gravitino/json/JsonUtils.java
Outdated
Show resolved
Hide resolved
mchades
reviewed
Jan 26, 2024
common/src/main/java/com/datastrato/gravitino/json/JsonUtils.java
Outdated
Show resolved
Hide resolved
mchades
reviewed
Jan 26, 2024
common/src/main/java/com/datastrato/gravitino/json/JsonUtils.java
Outdated
Show resolved
Hide resolved
mchades
reviewed
Jan 26, 2024
mchades
reviewed
Jan 26, 2024
...c/test/java/com/datastrato/gravitino/integration/test/catalog/jdbc/mysql/CatalogMysqlIT.java
Outdated
Show resolved
Hide resolved
yuqi1129
reviewed
Jan 26, 2024
...c/test/java/com/datastrato/gravitino/integration/test/catalog/jdbc/mysql/CatalogMysqlIT.java
Outdated
Show resolved
Hide resolved
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Show resolved
Hide resolved
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/datastrato/gravitino/json/JsonUtils.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 28, 2024
clients/client-java/src/test/java/com/datastrato/gravitino/client/TestRelationalCatalog.java
Show resolved
Hide resolved
Clearvive
force-pushed
the
1707/support-mysql-index
branch
from
e1d7d31 to
66bf56a
Compare
FANNG1
reviewed
Jan 29, 2024
...c/test/java/com/datastrato/gravitino/integration/test/catalog/jdbc/mysql/CatalogMysqlIT.java
Show resolved
Hide resolved
FANNG1
reviewed
Jan 29, 2024
...c/test/java/com/datastrato/gravitino/integration/test/catalog/jdbc/mysql/CatalogMysqlIT.java
Show resolved
Hide resolved
FANNG1
reviewed
Jan 29, 2024
...c/test/java/com/datastrato/gravitino/integration/test/catalog/jdbc/mysql/CatalogMysqlIT.java
Show resolved
Hide resolved
|
I'm ok to the current implement, please fix the comment and run pass the IT |
ok |
Clearvive
force-pushed
the
1707/support-mysql-index
branch
from
7569855 to
4c7f107
Compare
jerryshao
reviewed
Jan 29, 2024
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
approved these changes
Jan 29, 2024
|
@jerryshao do you have any other comment? |
ch3yne
pushed a commit
to ch3yne/gravitino
that referenced
this pull request
Jan 29, 2024
### What changes were proposed in this pull request? Support mysql index. ### Why are the changes needed? Fix: apache#1707 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? UT/IT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support mysql index.
Why are the changes needed?
Fix: #1707
Does this PR introduce any user-facing change?
NO
How was this patch tested?
UT/IT