Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1428] improvement(UI): Filtering empty keys when create or update #1430

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

Filtering empty keys when operating create or update.

image

After adding an empty key, the API will prompt an error message, so we need to prevent this from happening at the frontend level.

Why are the changes needed?

Fix: #1428

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

N/A

…1412)

### What changes were proposed in this pull request?

Filtering empty keys when operating create or update.

<img width="480" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/c2bbf850-dfe9-4419-9f6d-6d9cd2fbe0f1">

After adding an empty key, the API will prompt an error message, so we
need to prevent this from happening at the frontend level.

### Why are the changes needed?

Fix: #1428 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
@jerryshao jerryshao added cherry-pick need backport Issues that need to backport to another branch labels Jan 10, 2024
Copy link

Code Coverage Report

Overall Project 66% 🟢

There is no coverage information present for the Files changed

@mchades mchades merged commit cad1f33 into branch-0.3 Jan 10, 2024
4 checks passed
@qqqttt123 qqqttt123 deleted the cherry-pick-branch-0.3-fbd19c86e8864d1bfe3ac8eab26fa6bd15a93a61 branch January 10, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants