Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1350] fix(UI): Fix fields validation when create a catalog in the web UI #1387

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

Fix fields validation when create a catalog in the web UI.

Currently, after clicking submit, it will verify correctly based on the provider and specific properties.

Why are the changes needed?

Fix: #1350

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

N/A

…eb UI (#1375)

### What changes were proposed in this pull request?

Fix fields validation when create a catalog in the web UI.

Currently, after clicking submit, it will verify correctly based on the
`provider` and specific `properties`.

### Why are the changes needed?

Fix: #1350 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
@jerryshao jerryshao added cherry-pick need backport Issues that need to backport to another branch labels Jan 8, 2024
Copy link

github-actions bot commented Jan 8, 2024

Code Coverage Report

Overall Project 66% 🟢

There is no coverage information present for the Files changed

Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129 yuqi1129 merged commit f1bf283 into branch-0.3 Jan 9, 2024
4 checks passed
@qqqttt123 qqqttt123 deleted the cherry-pick-branch-0.3-ec5f799d883d186f3598962273ffa639855baa11 branch January 9, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants