Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1151] fix(UI): Fix status cache after modified a Metalake #1325

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jan 4, 2024

What changes were proposed in this pull request?

Fix the issue with the status cache after modifying Metalake.

Before:

  1. rename a metalake
test2-test3
  1. click create metalake button
update-metalake

It should be create dialog, but displays update dialog.

After:

when click create metalake button, correctly display create dialog.
create-metalake

Why are the changes needed?

Fix: #1151

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

N/A

### What changes were proposed in this pull request?

Fix the issue with the status cache after modifying Metalake.

#### Before:
1. rename a metalake
<img width="480" alt="test2-test3"
src="https://github.com/datastrato/gravitino/assets/17310559/c4f24dd8-9e07-4942-9f40-45c8b375bec6">

2. click `create metalake` button
<img width="480" alt="update-metalake"
src="https://github.com/datastrato/gravitino/assets/17310559/4fcc1040-8f91-4dd5-b62a-30c44c5a1b82">

It should be `create dialog`, but displays `update dialog`.

#### After:
when click `create metalake` button, correctly display `create dialog`.
<img width="480" alt="create-metalake"
src="https://github.com/datastrato/gravitino/assets/17310559/d833a7a7-d6cd-45ca-9e99-5156c68e5f10">


### Why are the changes needed?

Fix: #1151 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
@github-actions github-actions bot added cherry-pick need backport Issues that need to backport to another branch labels Jan 4, 2024
@github-actions github-actions bot requested a review from jerryshao January 4, 2024 06:16
@jerryshao jerryshao closed this Jan 4, 2024
@jerryshao jerryshao reopened this Jan 4, 2024
Copy link
Author

github-actions bot commented Jan 4, 2024

Code Coverage Report

Overall Project 66.02% 🟢

There is no coverage information present for the Files changed

@jerryshao jerryshao merged commit 3f40349 into branch-0.3 Jan 4, 2024
4 checks passed
@jerryshao jerryshao deleted the cherry-pick-branch-0.3-449a94ba16f15cf537798fa473c6aabd94ec4c6b branch January 4, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants