[#1231] Fix bugs in drop MySQL schemas #1235
Conversation
.../src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlDatabaseOperations.java
Outdated
Show resolved
Hide resolved
| if (cascade) { | ||
| throw new UnsupportedOperationException( | ||
| "MySQL does not support CASCADE option for DROP DATABASE."); | ||
| return dropDatabaseSql; |
There was a problem hiding this comment.
Need to handle database not empty.
There was a problem hiding this comment.
Is the condition !cascade?
There was a problem hiding this comment.
Is the condition
!cascade?
No, MySQL will automatically delete all tables in the database when it is removed.
There was a problem hiding this comment.
Why @Clearvive said that MySQL doesn't support cascading drop, have you verified with different MySQL versions, is it a consistent behavior?
There was a problem hiding this comment.
MySQL does support cascading deletion of schema, execute drop database {database_name} will drop all tables under it.
@Clearvive , Please check it.
|
@Clearvive can you please help to review? |
@Clearvive , could you please assist in viewing this? thanks |
.../src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlDatabaseOperations.java
Show resolved
Hide resolved
jerryshao
added
need backport
### What changes were proposed in this pull request? - Allow dropping a database when `cascase` is `true`. - If the database is not empty and `cascade` is `false`, disable the drop operation. ### Why are the changes needed? Align the logic with Gravitino EntityStore. Fix: #1231 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Add UT `testDropMySQLDatabase`
What changes were proposed in this pull request?
cascaseistrue.cascadeisfalse, disable the drop operation.Why are the changes needed?
Align the logic with Gravitino EntityStore.
Fix: #1231
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Add UT
testDropMySQLDatabase